From a6b8686ecbe6c09a3cb283c71fb386d9ab9acabd Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Tue, 1 Jun 2004 20:23:12 +0000 Subject: [PATCH] ext/flac/gstflactag.c: strip ending framing bit from vorbiscomment buffer since libflac doesn't expect it (reports a ... Original commit message from CVS: 2004-06-01 Christophe Fergeau * ext/flac/gstflactag.c: strip ending framing bit from vorbiscomment buffer since libflac doesn't expect it (reports a sync error when it encounters that) --- ChangeLog | 8 ++++++++ ext/flac/gstflactag.c | 12 ++++++++++++ 2 files changed, 20 insertions(+) diff --git a/ChangeLog b/ChangeLog index 27597ac120..3a2adfd86a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2004-06-01 Christophe Fergeau + + * ext/flac/gstflactag.c: strip ending framing bit from vorbiscomment + buffer since libflac doesn't expect it (reports a sync error when + it encounters that) + + 2004-06-01 Owen Fraser-Green * gst-libs/gst/mixer/mixertrack.h: Changed struct syntax @@ -10,6 +17,7 @@ * gst-libs/gst/mixer/mixer.h: Changed GstMixerClass syntax * gst-libs/gst/mixer/mixer.c: Fixed comment + 2004-06-01 Thomas Vander Stichele * ext/alsa/gstalsa.c: (gst_alsa_open_audio): diff --git a/ext/flac/gstflactag.c b/ext/flac/gstflactag.c index 229cacf96d..cbf2964b3d 100644 --- a/ext/flac/gstflactag.c +++ b/ext/flac/gstflactag.c @@ -518,6 +518,18 @@ gst_flac_tag_chain (GstPad * pad, GstData * data) ("Vorbis comment of size %d too long", size)); return; } + + /* Get rid of the framing bit at the end of the vorbiscomment buffer + * if it exists since libFLAC seems to lose sync because of this + * bit in gstflacdec + */ + if (GST_BUFFER_DATA (buffer)[GST_BUFFER_SIZE (buffer) - 1] == 1) { + GstBuffer *sub; + + sub = gst_buffer_create_sub (buffer, 0, GST_BUFFER_SIZE (buffer) - 1); + gst_buffer_unref (buffer); + buffer = sub; + } } /* The 4 byte metadata block header isn't accounted for in the total