From a4d3d80e958475f3821eb0a246c5e76c37802722 Mon Sep 17 00:00:00 2001 From: Elizabeth Figura Date: Mon, 26 Feb 2024 19:17:27 -0600 Subject: [PATCH] qtdemux: Do not set channel-mask to zero Leave it uninitialized, so that the downstream decoder will initialize it appropriately. Setting it to zero is wrong. Part-of: --- subprojects/gst-plugins-good/gst/isomp4/qtdemux.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c b/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c index 2b452250a4..068a569a5f 100644 --- a/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c +++ b/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c @@ -9583,13 +9583,8 @@ gst_qtdemux_configure_stream (GstQTDemux * qtdemux, QtDemuxStream * stream) if (CUR_STREAM (stream)->n_channels > 0) gst_caps_set_simple (CUR_STREAM (stream)->caps, "channels", G_TYPE_INT, CUR_STREAM (stream)->n_channels, NULL); - if (CUR_STREAM (stream)->n_channels > 2) { - /* FIXME: Need to parse the 'chan' atom to get channel layouts - * correctly; this is just the minimum we can do - assume - * we don't actually have any channel positions. */ - gst_caps_set_simple (CUR_STREAM (stream)->caps, - "channel-mask", GST_TYPE_BITMASK, G_GUINT64_CONSTANT (0), NULL); - } + /* FIXME: Need to parse the 'chan' atom to get channel layouts + * correctly. */ } }