From a498d3fe6e2bedd2e1622bb51811d44c8fabd6ed Mon Sep 17 00:00:00 2001 From: George Kiagiadakis Date: Mon, 12 Feb 2018 15:33:49 +0200 Subject: [PATCH] adder: remove non-interleaved layout from caps adder needs more than just trivial work to support planar buffers properly because it currently reads sub-buffers from GstCollectPads in order for all of them to have matching sizes. In planar mode, this means it would truncate some channels and mix them up in strange ways. It only works if all input buffers in all sink pads have matching sizes. --- gst/adder/gstadder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gst/adder/gstadder.c b/gst/adder/gstadder.c index dce05f677a..f73b6dbffd 100644 --- a/gst/adder/gstadder.c +++ b/gst/adder/gstadder.c @@ -167,11 +167,11 @@ enum #if G_BYTE_ORDER == G_LITTLE_ENDIAN #define CAPS \ GST_AUDIO_CAPS_MAKE ("{ S32LE, U32LE, S16LE, U16LE, S8, U8, F32LE, F64LE }") \ - ", layout = (string) { interleaved, non-interleaved }" + ", layout = (string) { interleaved }" #else #define CAPS \ GST_AUDIO_CAPS_MAKE ("{ S32BE, U32BE, S16BE, U16BE, S8, U8, F32BE, F64BE }") \ - ", layout = (string) { interleaved, non-interleaved }" + ", layout = (string) { interleaved }" #endif static GstStaticPadTemplate gst_adder_src_template =