From a46f0862cd47ace1cba2a245d54b7e4735a31d88 Mon Sep 17 00:00:00 2001
From: Wim Taymans <wim.taymans@collabora.co.uk>
Date: Mon, 6 Feb 2012 09:46:47 +0100
Subject: [PATCH] gst: improve debugging

---
 gst/gstbuffer.c     | 1 +
 gst/gstminiobject.c | 3 ++-
 gst/gstpad.c        | 2 ++
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gst/gstbuffer.c b/gst/gstbuffer.c
index 2ab9f6947c..3eb0f65960 100644
--- a/gst/gstbuffer.c
+++ b/gst/gstbuffer.c
@@ -985,6 +985,7 @@ gst_buffer_map (GstBuffer * buffer, GstMapInfo * info, GstMapFlags flags)
   /* ERROR */
 not_writable:
   {
+    GST_WARNING_OBJECT (buffer, "write map requested on non-writable buffer");
     g_critical ("write map requested on non-writable buffer");
     return FALSE;
   }
diff --git a/gst/gstminiobject.c b/gst/gstminiobject.c
index eff3bb4490..6d666218a7 100644
--- a/gst/gstminiobject.c
+++ b/gst/gstminiobject.c
@@ -214,13 +214,14 @@ void
 gst_mini_object_unref (GstMiniObject * mini_object)
 {
   g_return_if_fail (mini_object != NULL);
-  g_return_if_fail (mini_object->refcount > 0);
 
   GST_CAT_TRACE (GST_CAT_REFCOUNTING, "%p unref %d->%d",
       mini_object,
       GST_MINI_OBJECT_REFCOUNT_VALUE (mini_object),
       GST_MINI_OBJECT_REFCOUNT_VALUE (mini_object) - 1);
 
+  g_return_if_fail (mini_object->refcount > 0);
+
   if (G_UNLIKELY (g_atomic_int_dec_and_test (&mini_object->refcount))) {
     gboolean do_free;
 
diff --git a/gst/gstpad.c b/gst/gstpad.c
index f900acf6c5..92b1ea517e 100644
--- a/gst/gstpad.c
+++ b/gst/gstpad.c
@@ -4250,6 +4250,8 @@ not_accepted:
     gst_caps_unref (templ);
     GST_CAT_DEBUG_OBJECT (GST_CAT_CAPS, pad,
         "caps %" GST_PTR_FORMAT " not accepted", caps);
+    GST_CAT_DEBUG_OBJECT (GST_CAT_CAPS, pad,
+        "no intersection with template %" GST_PTR_FORMAT, templ);
     return GST_FLOW_NOT_NEGOTIATED;
   }
 }