From a25253130b573c842805439e424eb048c1ef9bbc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Tue, 22 Sep 2015 14:43:44 +0200 Subject: [PATCH] mpdparser: Only check stream->segments for a repeated last segment if we have a static list of segments Otherwise we'll crash, trying to derefence NULL. And if we have no static list of segments, we can't have repeated segments anyway. Regression introduced by cfe2871a5e3c5b1db20470927642b776e055a87a https://bugzilla.gnome.org/show_bug.cgi?id=755411 --- ext/dash/gstmpdparser.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ext/dash/gstmpdparser.c b/ext/dash/gstmpdparser.c index 9172f552b3..743f7ff6b1 100644 --- a/ext/dash/gstmpdparser.c +++ b/ext/dash/gstmpdparser.c @@ -4057,7 +4057,8 @@ gst_mpd_client_has_next_segment (GstMpdClient * client, if (forward) { guint segments_count = gst_mpd_client_get_segments_counts (client, stream); - if (segments_count > 0 && stream->segment_index + 1 == segments_count) { + if (segments_count > 0 && stream->segments + && stream->segment_index + 1 == segments_count) { GstMediaSegment *segment; segment = g_ptr_array_index (stream->segments, stream->segment_index);