From a1da4cd733185043a87bb3c1953db37ebedcb0d0 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Mon, 16 Feb 2015 19:24:23 +0100 Subject: [PATCH] validate-report: Fix valist usage a va_list always 'exists' (it's a struct). It therefore can't be NULL (and can't be tested) Just use the regular print variant where appropriate. --- validate/gst/validate/gst-validate-report.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/validate/gst/validate/gst-validate-report.c b/validate/gst/validate/gst-validate-report.c index 80061206dc..3de1a1794a 100644 --- a/validate/gst/validate/gst-validate-report.c +++ b/validate/gst/validate/gst-validate-report.c @@ -516,7 +516,7 @@ gst_validate_printf (gpointer source, const gchar * format, ...) void gst_validate_print_action (GstValidateAction * action, const gchar * message) { - gst_validate_printf_valist (action, message, NULL); + gst_validate_printf (action, "%s", message); } static void @@ -652,10 +652,7 @@ gst_validate_printf_valist (gpointer source, const gchar * format, va_list args) } } - if (args) - g_string_append_vprintf (string, format, args); - else - g_string_append (string, format); + g_string_append_vprintf (string, format, args); if (!newline_regex) newline_regex =