From 9ec99ac6f2d5d2310ea081840148849d2e4e1553 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Tue, 9 Apr 2024 18:36:12 +0100 Subject: [PATCH] analyticsmeta: fix g-ir-scanner warnings Fix gstanalyticsmeta.c:134: Warning: GstAnalytics: "@instance" parameter unexpected at this location warning (caused by the extraneous empty line in the doc chunk) and align function arguments with documentation and header file (handle -> instance). Part-of: --- .../gst-libs/gst/analytics/gstanalyticsmeta.c | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/analytics/gstanalyticsmeta.c b/subprojects/gst-plugins-bad/gst-libs/gst/analytics/gstanalyticsmeta.c index bcec73470a..64fc0176f2 100644 --- a/subprojects/gst-plugins-bad/gst-libs/gst/analytics/gstanalyticsmeta.c +++ b/subprojects/gst-plugins-bad/gst-libs/gst/analytics/gstanalyticsmeta.c @@ -130,7 +130,6 @@ gst_analytics_relation_meta_get_mtd_data_internal (GstAnalyticsRelationMeta * /** * gst_analytics_mtd_get_mtd_type: - * * @instance: Instance of #GstAnalyticsMtd * Get analysis result type. * @@ -138,11 +137,12 @@ gst_analytics_relation_meta_get_mtd_data_internal (GstAnalyticsRelationMeta * * Since: 1.24 */ GstAnalyticsMtdType -gst_analytics_mtd_get_mtd_type (GstAnalyticsMtd * handle) +gst_analytics_mtd_get_mtd_type (GstAnalyticsMtd * instance) { GstAnalyticsRelatableMtdData *rlt; - rlt = gst_analytics_relation_meta_get_mtd_data_internal (handle->meta, - handle->id); + + rlt = gst_analytics_relation_meta_get_mtd_data_internal (instance->meta, + instance->id); g_return_val_if_fail (rlt != NULL, 0); @@ -159,9 +159,9 @@ gst_analytics_mtd_get_mtd_type (GstAnalyticsMtd * handle) * Since: 1.24 */ guint -gst_analytics_mtd_get_id (GstAnalyticsMtd * handle) +gst_analytics_mtd_get_id (GstAnalyticsMtd * instance) { - return handle->id; + return instance->id; } /** @@ -174,11 +174,13 @@ gst_analytics_mtd_get_id (GstAnalyticsMtd * handle) * Since: 1.24 */ gsize -gst_analytics_mtd_get_size (GstAnalyticsMtd * handle) +gst_analytics_mtd_get_size (GstAnalyticsMtd * instance) { GstAnalyticsRelatableMtdData *rlt; - rlt = gst_analytics_relation_meta_get_mtd_data_internal (handle->meta, - handle->id); + + rlt = gst_analytics_relation_meta_get_mtd_data_internal (instance->meta, + instance->id); + if (rlt == NULL) { GST_CAT_ERROR (GST_CAT_AN_RELATION, "Invalid parameter"); return 0;