From 9d3b57f3627e33d3161d1808045a71b957591ad4 Mon Sep 17 00:00:00 2001 From: Stephan Seitz Date: Sat, 26 Aug 2023 15:12:05 +0200 Subject: [PATCH] sdp: fix wrong error message for missing clock-rate in caps When using `gst_sdp_media_set_media_from_caps` on `application/x-rtp` caps without `clock-rate` it wrongly reports missing payload type even if `payload` is present in the caps. This seems to be a copy&paste error from the error message for missing payload type. When using payload=10, both `clock-rate` and some other media properties are defined by the RTP standard so I was wondering whether I could omit `clock-rate` and was confused about the error message. Part-of: --- subprojects/gst-plugins-base/gst-libs/gst/sdp/gstsdpmessage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-base/gst-libs/gst/sdp/gstsdpmessage.c b/subprojects/gst-plugins-base/gst-libs/gst/sdp/gstsdpmessage.c index 0ef3dab456..e98e5fd05a 100644 --- a/subprojects/gst-plugins-base/gst-libs/gst/sdp/gstsdpmessage.c +++ b/subprojects/gst-plugins-base/gst-libs/gst/sdp/gstsdpmessage.c @@ -3851,7 +3851,7 @@ gst_sdp_media_set_media_from_caps (const GstCaps * caps, GstSDPMedia * media) /* get clock-rate, media type and params for the rtpmap attribute */ if (!gst_structure_get_int (s, "clock-rate", &caps_rate)) { - GST_ERROR ("ignoring stream without payload type"); + GST_ERROR ("ignoring stream without clock rate"); goto error; } caps_enc = gst_structure_get_string (s, "encoding-name");