From 9adefac59b262f7ec44ec1ececa00a2c69dd98e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Wed, 13 May 2015 12:31:44 +0100 Subject: [PATCH] srtpenc: fix failure return values from create_session() create_session() returns an err_status_t with err_status_ok=0 and err_status_fail=1, so returning TRUE/FALSE is not quite right. https://bugzilla.gnome.org/show_bug.cgi?id=749304 --- ext/srtp/gstsrtpenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/srtp/gstsrtpenc.c b/ext/srtp/gstsrtpenc.c index f5e3f13f74..8489da42be 100644 --- a/ext/srtp/gstsrtpenc.c +++ b/ext/srtp/gstsrtpenc.c @@ -428,7 +428,7 @@ gst_srtp_enc_create_session (GstSrtpEnc * filter) GST_ELEMENT_ERROR (filter, LIBRARY, SETTINGS, ("Cipher is not NULL, key must be set"), ("Cipher is not NULL, key must be set")); - return FALSE; + return err_status_fail; } expected = max_cipher_key_size (filter); @@ -439,7 +439,7 @@ gst_srtp_enc_create_session (GstSrtpEnc * filter) ("Master key size is wrong"), ("Expected master key of %d bytes, but received %" G_GSIZE_FORMAT " bytes", expected, keysize)); - return FALSE; + return err_status_fail; } }