From 9ab400e26754e1c47accba2e135bf0990b0f04e4 Mon Sep 17 00:00:00 2001 From: Marijn Suijten Date: Fri, 29 Jan 2021 21:40:33 +0100 Subject: [PATCH] gstaudiostreamalign: Pass self as const pointer in getter functions It was noticed in [1] that `GstAudioStreamAlign` is a simple boxed type that is passed as const in the copy function, but not as such in the getters. These functions turn out to be the only users of `const = true` overrides in `gstreamer-rs`. Since there is no locking or other advanced caching/sharing going on (as happens with miniobjects) these functions can safely take self as const pointer. [1]: https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/683#note_783129 Part-of: --- gst-libs/gst/audio/gstaudiostreamalign.c | 13 ++++++++----- gst-libs/gst/audio/gstaudiostreamalign.h | 10 +++++----- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/gst-libs/gst/audio/gstaudiostreamalign.c b/gst-libs/gst/audio/gstaudiostreamalign.c index 3eaa74bc97..ec4233d4ee 100644 --- a/gst-libs/gst/audio/gstaudiostreamalign.c +++ b/gst-libs/gst/audio/gstaudiostreamalign.c @@ -172,7 +172,7 @@ gst_audio_stream_align_set_rate (GstAudioStreamAlign * align, gint rate) * Since: 1.14 */ gint -gst_audio_stream_align_get_rate (GstAudioStreamAlign * align) +gst_audio_stream_align_get_rate (const GstAudioStreamAlign * align) { g_return_val_if_fail (align != NULL, 0); @@ -208,7 +208,8 @@ gst_audio_stream_align_set_alignment_threshold (GstAudioStreamAlign * * Since: 1.14 */ GstClockTime -gst_audio_stream_align_get_alignment_threshold (GstAudioStreamAlign * align) +gst_audio_stream_align_get_alignment_threshold (const GstAudioStreamAlign * + align) { g_return_val_if_fail (align != NULL, 0); @@ -244,7 +245,7 @@ gst_audio_stream_align_set_discont_wait (GstAudioStreamAlign * align, * Since: 1.14 */ GstClockTime -gst_audio_stream_align_get_discont_wait (GstAudioStreamAlign * align) +gst_audio_stream_align_get_discont_wait (const GstAudioStreamAlign * align) { g_return_val_if_fail (align != NULL, 0); @@ -280,7 +281,8 @@ gst_audio_stream_align_mark_discont (GstAudioStreamAlign * align) * Since: 1.14 */ GstClockTime -gst_audio_stream_align_get_timestamp_at_discont (GstAudioStreamAlign * align) +gst_audio_stream_align_get_timestamp_at_discont (const GstAudioStreamAlign * + align) { g_return_val_if_fail (align != NULL, GST_CLOCK_TIME_NONE); @@ -299,7 +301,8 @@ gst_audio_stream_align_get_timestamp_at_discont (GstAudioStreamAlign * align) * Since: 1.14 */ guint64 -gst_audio_stream_align_get_samples_since_discont (GstAudioStreamAlign * align) +gst_audio_stream_align_get_samples_since_discont (const GstAudioStreamAlign * + align) { g_return_val_if_fail (align != NULL, 0); diff --git a/gst-libs/gst/audio/gstaudiostreamalign.h b/gst-libs/gst/audio/gstaudiostreamalign.h index 80b83f927d..080e9ea44b 100644 --- a/gst-libs/gst/audio/gstaudiostreamalign.h +++ b/gst-libs/gst/audio/gstaudiostreamalign.h @@ -54,29 +54,29 @@ GST_AUDIO_API void gst_audio_stream_align_set_rate (GstAudioStreamAlign * align, gint rate); GST_AUDIO_API -gint gst_audio_stream_align_get_rate (GstAudioStreamAlign * align); +gint gst_audio_stream_align_get_rate (const GstAudioStreamAlign * align); GST_AUDIO_API void gst_audio_stream_align_set_alignment_threshold (GstAudioStreamAlign * align, GstClockTime alignment_threshold); GST_AUDIO_API -GstClockTime gst_audio_stream_align_get_alignment_threshold (GstAudioStreamAlign * align); +GstClockTime gst_audio_stream_align_get_alignment_threshold (const GstAudioStreamAlign * align); GST_AUDIO_API void gst_audio_stream_align_set_discont_wait (GstAudioStreamAlign * align, GstClockTime discont_wait); GST_AUDIO_API -GstClockTime gst_audio_stream_align_get_discont_wait (GstAudioStreamAlign * align); +GstClockTime gst_audio_stream_align_get_discont_wait (const GstAudioStreamAlign * align); GST_AUDIO_API void gst_audio_stream_align_mark_discont (GstAudioStreamAlign * align); GST_AUDIO_API -GstClockTime gst_audio_stream_align_get_timestamp_at_discont (GstAudioStreamAlign * align); +GstClockTime gst_audio_stream_align_get_timestamp_at_discont (const GstAudioStreamAlign * align); GST_AUDIO_API -guint64 gst_audio_stream_align_get_samples_since_discont (GstAudioStreamAlign * align); +guint64 gst_audio_stream_align_get_samples_since_discont (const GstAudioStreamAlign * align); GST_AUDIO_API gboolean gst_audio_stream_align_process (GstAudioStreamAlign * align,