From 9a5ca61f87f072b5a5b82d8fc4ec0333f192518c Mon Sep 17 00:00:00 2001
From: Philippe Normand <philn@igalia.com>
Date: Wed, 24 Jan 2024 12:36:48 +0000
Subject: [PATCH] vp9parse: Fix critical warning during caps negotiation

`gst_pad_get_allowed_caps()` returns a non-writable caps, so we need to make it
writable, otherwise the `gst_caps_remove_structure()` call below might trigger a
critical warning.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5975>
---
 subprojects/gst-plugins-bad/gst/videoparsers/gstvp9parse.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/subprojects/gst-plugins-bad/gst/videoparsers/gstvp9parse.c b/subprojects/gst-plugins-bad/gst/videoparsers/gstvp9parse.c
index c859054c0a..f5ed34ce75 100644
--- a/subprojects/gst-plugins-bad/gst/videoparsers/gstvp9parse.c
+++ b/subprojects/gst-plugins-bad/gst/videoparsers/gstvp9parse.c
@@ -290,6 +290,7 @@ gst_vp9_parse_negotiate (GstVp9Parse * self, GstVp9ParseAligment in_align,
   /* concentrate on leading structure, since decodebin parser
    * capsfilter always includes parser template caps */
   if (caps) {
+    caps = gst_caps_make_writable (caps);
     while (gst_caps_get_size (caps) > 0) {
       GstStructure *s = gst_caps_get_structure (caps, 0);