From 99897dbf2499cdf14f2d6d64539fbcfde4ebb05f Mon Sep 17 00:00:00 2001
From: Stefan Kost <ensonic@users.sourceforge.net>
Date: Thu, 22 Nov 2007 15:59:01 +0000
Subject: [PATCH] docs/random/ensonic/profiling.txt: More ideas.

Original commit message from CVS:
* docs/random/ensonic/profiling.txt:
More ideas.
* gst/gstbin.c:
Fix typo and give better log output.
* gst/gstdebugutils.c:
* gst/gstdebugutils.h:
More ideas, make graphs a bit smaller and fix param name in macro.
---
 ChangeLog                         | 12 ++++++++++++
 docs/random/ensonic/profiling.txt |  6 +++++-
 gst/gstbin.c                      | 11 ++++++++++-
 gst/gstdebugutils.c               | 10 +++++++++-
 gst/gstdebugutils.h               |  2 +-
 5 files changed, 37 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 330cee72c4..830f0f22c8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2007-11-22  Stefan Kost  <ensonic@users.sf.net>
+
+	* docs/random/ensonic/profiling.txt:
+	  More ideas.
+
+	* gst/gstbin.c:
+	  Fix typo and give better log output.
+
+	* gst/gstdebugutils.c:
+	* gst/gstdebugutils.h:
+	  More ideas, make graphs a bit smaller and fix param name in macro.
+
 2007-11-22  Stefan Kost  <ensonic@users.sf.net>
 
 	* gst/gstpreset.c:
diff --git a/docs/random/ensonic/profiling.txt b/docs/random/ensonic/profiling.txt
index 0866c6957e..cb11475fd2 100644
--- a/docs/random/ensonic/profiling.txt
+++ b/docs/random/ensonic/profiling.txt
@@ -3,7 +3,7 @@ $Id$
 = profiling =
 
 == what information is interesting? ==
-* pipeline through-output
+* pipeline throughput
   if we know the cpu-load for a given datastream, we could extrapolate what the
   system can handle
   -> qos profiling
@@ -104,6 +104,9 @@ Sensors do meassurements and deliver timestampe performance data.
   * when (gst_clock_get_time) ?
   * we want it per thread
 * queue fill levels
+* number of
+  * threads
+  * open files
 
 == Wanted Sensors ==
 * dropped buffers
@@ -127,6 +130,7 @@ timestamp [qos-ratio] [cpu-load={sum,17284,17285}]
 == Running ==
 LD_PRELOAD=libgstperfmon.so GST_PERFMON_DETAILS="qos-ratio,cpu-load=all" <application>
 LD_PRELOAD=libgstperfmon.so GST_PERFMON_DETAILS="qos-ratio,cpu-load=sum" <application>
+LD_PRELOAD=libgstperfmon.so GST_PERFMON_DETAILS="*" <application>
 
 == Exploration
 pygtk ui, mathplotlib
diff --git a/gst/gstbin.c b/gst/gstbin.c
index e05a1edf87..f0a251a485 100644
--- a/gst/gstbin.c
+++ b/gst/gstbin.c
@@ -735,11 +735,20 @@ find_message (GstBin * bin, GstObject * src, GstMessageType types)
       (GCompareFunc) message_check);
 
   if (result) {
-    GST_DEBUG_OBJECT (bin, "we found a message %p from %s mathing types %08x",
+    GST_DEBUG_OBJECT (bin, "we found a message %p from %s matching types %08x",
         result->data, GST_OBJECT_NAME (GST_MESSAGE_CAST (result->data)->src),
         types);
   } else {
     GST_DEBUG_OBJECT (bin, "no message found matching types %08x", types);
+#ifndef GST_DISABLE_GST_DEBUG
+    {
+      guint i;
+
+      for (i = 0; i < 32; i++)
+        if (types & (1 << i))
+          GST_DEBUG_OBJECT (bin, "  %s", gst_message_type_get_name (1 << i));
+    }
+#endif
   }
 
   return result;
diff --git a/gst/gstdebugutils.c b/gst/gstdebugutils.c
index 2e2b717efa..de04573108 100644
--- a/gst/gstdebugutils.c
+++ b/gst/gstdebugutils.c
@@ -18,6 +18,13 @@
  * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
  * Boston, MA 02111-1307, USA.
  */
+/* TODO:
+ * edge [ constraint=false ];
+ * edge [ minlen=0 ];
+ *   does not create spacial dependency
+ * node [ margin="0.02,0.01" ];
+ *   space surrounding the label
+ */
 
 #include "gst_private.h"
 #include "gstdebugutils.h"
@@ -453,7 +460,8 @@ _gst_debug_bin_to_dot_file (GstBin * bin, GstDebugGraphDetails details,
         "  fontname=\"Bitstream Vera Sans\";\n"
         "  fontsize=\"8\";\n"
         "  labelloc=t;\n"
-        "  nodesep=.15;\n"
+        "  nodesep=.1;\n"
+        "  ranksep=.2;\n"
         "  label=\"<%s>\\n%s%s%s\";\n"
         "  node [style=filled, shape=box, fontsize=\"7\", fontname=\"Bitstream Vera Sans\"];\n"
         "  edge [labelfontsize=\"7\", fontsize=\"7\", labelfontname=\"Bitstream Vera Sans\", fontname=\"Bitstream Vera Sans\"];\n"
diff --git a/gst/gstdebugutils.h b/gst/gstdebugutils.h
index d3edaa43c1..c84643d3ac 100644
--- a/gst/gstdebugutils.h
+++ b/gst/gstdebugutils.h
@@ -91,7 +91,7 @@ void _gst_debug_bin_to_dot_file_with_ts (GstBin *bin, GstDebugGraphDetails detai
 
 
 #define GST_DEBUG_BIN_TO_DOT_FILE(bin, details, file_name)
-#define GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(bin, details, file_tmpl)
+#define GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(bin, details, file_name)
 
 #endif /* GST_DISABLE_GST_DEBUG */