From 995a135df6276a060ce16078fd6db54668163199 Mon Sep 17 00:00:00 2001 From: Jordan Petridis Date: Wed, 15 Jul 2020 10:49:03 +0300 Subject: [PATCH] amrnbenc: remove global variables gstcheck is declaring its own buffers glist which ends up overwritten, loks like the code meant to use that already gcc 10 is also complaining about this, but only on static builds for some reason ``` FAILED: subprojects/gst-plugins-ugly/tests/check/elements_amrnbenc /usr/bin/ld: subprojects/gstreamer/libs/gst/check/libgstcheck-1.0.a(gstcheck.c.o):(.bss+0x38): multiple definition of `buffers'; subprojects/gst-plugins-ugly/tests/check/708af1f@@elements_amrnbenc@exe/elements_amrnbenc.c.o:(.bss+0x18): first defined here collect2: error: ld returned 1 exit status ``` also remove unused var `current_buf` Part-of: --- tests/check/elements/amrnbenc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/check/elements/amrnbenc.c b/tests/check/elements/amrnbenc.c index 4f9b4b5082..3875e80a76 100644 --- a/tests/check/elements/amrnbenc.c +++ b/tests/check/elements/amrnbenc.c @@ -28,10 +28,7 @@ "layout = (string) interleaved, channels = (int) 1, rate = (int) 8000" #define SINK_CAPS "audio/AMR" -GList *buffers; -GList *current_buf = NULL; - -GstPad *srcpad, *sinkpad; +static GstPad *srcpad, *sinkpad; static GstStaticPadTemplate sinktemplate = GST_STATIC_PAD_TEMPLATE ("sink", GST_PAD_SINK,