From 9870783f0158efc6573c5ae6eabafafdf981496e Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Sun, 14 Jul 2019 16:42:17 -0400 Subject: [PATCH] eglimage: Fix extension names in dmabuf import check There was a typo in the extension name which resulted in the modifiers to never be set when doing DMABuf import. That triggered the modifiers lookup in Intel driver, which was in fact hiding bugs in the gldownload to glupload path when doing DMABuf. Note, this changes breaks pipeline the following pipeline on Intel and some other drivers: gltestsrc ! gldownload ! video/x-raw\(memory:DMABuf\) ! glimagsink A fix for this was added to Mesa recently: Related to https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1338 Fixes 5d0e191710 --- gst-libs/gst/gl/egl/gsteglimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gst-libs/gst/gl/egl/gsteglimage.c b/gst-libs/gst/gl/egl/gsteglimage.c index 6ae5e0e30c..43904be40c 100644 --- a/gst-libs/gst/gl/egl/gsteglimage.c +++ b/gst-libs/gst/gl/egl/gsteglimage.c @@ -860,7 +860,7 @@ gst_egl_image_from_dmabuf_direct (GstGLContext * context, return NULL; with_modifiers = gst_gl_context_check_feature (context, - "EGL_EXT_image_dma_buf_import_with_modifiers"); + "EGL_EXT_image_dma_buf_import_modifiers"); /* EGL DMABuf importation supports a maximum of 3 planes */ if (G_UNLIKELY (n_planes > 3))