diff --git a/ChangeLog b/ChangeLog index d02427a49e..56ea378fb9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,28 @@ +2004-08-03 Benjamin Otte + + * examples/dynparams/filter.c: (ui_control_create): + * examples/gstplay/player.c: (print_tag): + * ext/alsa/gstalsa.c: (gst_alsa_request_new_pad): + * ext/gdk_pixbuf/gstgdkanimation.c: + (gst_gdk_animation_iter_may_advance): + * ext/jack/gstjack.c: (gst_jack_request_new_pad): + * ext/mad/gstid3tag.c: (gst_mad_id3_to_tag_list), + (tag_list_to_id3_tag_foreach), (gst_id3_tag_handle_event): + * ext/vorbis/oggvorbisenc.c: (gst_oggvorbisenc_get_tag_value): + * ext/vorbis/vorbisenc.c: (gst_vorbisenc_get_tag_value): + * ext/xine/xineaudiodec.c: (gst_xine_audio_dec_chain): + * gst-libs/gst/media-info/media-info-test.c: (print_tag): + * gst/sine/demo-dparams.c: (main): + * gst/tags/gstvorbistag.c: (gst_tag_to_vorbis_comments): + * testsuite/alsa/formats.c: (create_pipeline): + * testsuite/alsa/sinesrc.c: (sinesrc_force_caps), (sinesrc_get): + fixes for G_DISABLE_ASSERT and friends + * gst/typefind/gsttypefindfunctions.c: (aac_type_find), + (mp3_type_frame_length_from_header), (mp3_type_find), + (plugin_init): + require mp3 typefinding to have at least MIN_HEADERS valid headers + add typefinding for AAC adts files + 2004-08-04 Jan Schmidt * sys/ximage/ximagesink.c: diff --git a/examples/dynparams/filter.c b/examples/dynparams/filter.c index 5178d28bdc..333820df1f 100644 --- a/examples/dynparams/filter.c +++ b/examples/dynparams/filter.c @@ -183,8 +183,9 @@ ui_control_create (GstElement * element, GtkWidget * control, _filter_ui_t * ui) /* create the dparam object */ dparam = gst_dpsmooth_new (G_PARAM_SPEC_VALUE_TYPE (specs[i])); g_object_set (G_OBJECT (dparam), "update_period", 2000000LL, NULL); - g_assert (gst_dpman_attach_dparam (dpman, - (gchar *) g_param_spec_get_name (specs[i]), dparam)); + if (!gst_dpman_attach_dparam (dpman, + (gchar *) g_param_spec_get_name (specs[i]), dparam)) + g_assert_not_reached (); gst_dpman_set_mode (dpman, "asynchronous"); g_signal_connect (widget, "value-changed", G_CALLBACK (cb_dynparm_value_changed), dparam); diff --git a/examples/gstplay/player.c b/examples/gstplay/player.c index 4258d6459f..ca76978ecb 100644 --- a/examples/gstplay/player.c +++ b/examples/gstplay/player.c @@ -34,7 +34,8 @@ print_tag (const GstTagList * list, const gchar * tag, gpointer unused) gchar *str; if (gst_tag_get_type (tag) == G_TYPE_STRING) { - g_assert (gst_tag_list_get_string_index (list, tag, i, &str)); + if (!gst_tag_list_get_string_index (list, tag, i, &str)) + g_assert_not_reached (); } else { str = g_strdup_value_contents (gst_tag_list_get_value_index (list, tag, i)); diff --git a/ext/mad/gstid3tag.c b/ext/mad/gstid3tag.c index 16efc56900..dfa0a40891 100644 --- a/ext/mad/gstid3tag.c +++ b/ext/mad/gstid3tag.c @@ -622,7 +622,7 @@ gst_mad_id3_to_tag_list (const struct id3_tag * tag) { guint64 tmp; - g_assert ((strcmp (tag_name, GST_TAG_DURATION) == 0)); + g_assert (strcmp (tag_name, GST_TAG_DURATION) == 0); tmp = strtoul (utf8, NULL, 10); if (tmp == 0) { break; @@ -678,7 +678,8 @@ tag_list_to_id3_tag_foreach (const GstTagList * list, const gchar * tag_name, guint u; GDate *d; - g_assert (gst_tag_list_get_uint_index (list, tag_name, values, &u)); + if (!gst_tag_list_get_uint_index (list, tag_name, values, &u)) + g_assert_not_reached (); d = g_date_new_julian (u); str = g_strdup_printf ("%u", (guint) (g_date_get_year (d))); put = g_utf8_to_ucs4_fast (str, -1, NULL); @@ -688,7 +689,8 @@ tag_list_to_id3_tag_foreach (const GstTagList * list, const gchar * tag_name, gchar *str; guint u; - g_assert (gst_tag_list_get_uint_index (list, tag_name, values, &u)); + if (!gst_tag_list_get_uint_index (list, tag_name, values, &u)) + g_assert_not_reached (); str = g_strdup_printf ("%u", u); put = g_utf8_to_ucs4_fast (str, -1, NULL); g_free (str); @@ -699,7 +701,8 @@ tag_list_to_id3_tag_foreach (const GstTagList * list, const gchar * tag_name, GST_WARNING ("unhandled GStreamer tag %s", tag_name); return; } - g_assert (gst_tag_list_get_string_index (list, tag_name, values, &str)); + if (!gst_tag_list_get_string_index (list, tag_name, values, &str)) + g_assert_not_reached (); put = g_utf8_to_ucs4_fast (str, -1, NULL); g_free (str); } @@ -840,7 +843,8 @@ gst_id3_tag_handle_event (GstPad * pad, GstEvent * event) id3_tag_options (id3, ID3_TAG_OPTION_ID3V1, ID3_TAG_OPTION_ID3V1); tag_buffer = gst_buffer_new_and_alloc (128); - g_assert (128 == id3_tag_render (id3, tag_buffer->data)); + if (128 != id3_tag_render (id3, tag_buffer->data)) + g_assert_not_reached (); gst_pad_push (tag->srcpad, GST_DATA (tag_buffer)); id3_tag_delete (id3); } diff --git a/gst-libs/gst/media-info/media-info-test.c b/gst-libs/gst/media-info/media-info-test.c index e0778d9f44..4013b3ed97 100644 --- a/gst-libs/gst/media-info/media-info-test.c +++ b/gst-libs/gst/media-info/media-info-test.c @@ -15,7 +15,8 @@ print_tag (const GstTagList * list, const gchar * tag, gpointer unused) gchar *str; if (gst_tag_get_type (tag) == G_TYPE_STRING) { - g_assert (gst_tag_list_get_string_index (list, tag, i, &str)); + if (!gst_tag_list_get_string_index (list, tag, i, &str)) + g_assert_not_reached (); } else { str = g_strdup_value_contents (gst_tag_list_get_value_index (list, tag, i));