From 94fe5c690e757ef986f7ba4eee1a068eded07bf4 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Wed, 12 Apr 2017 10:54:23 +0200 Subject: [PATCH] mpdparser: Fix leak The error: location takes care of freeing new_representation CID #1405027 --- ext/dash/gstmpdparser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/dash/gstmpdparser.c b/ext/dash/gstmpdparser.c index bfb3cb6bf4..41212abae3 100644 --- a/ext/dash/gstmpdparser.c +++ b/ext/dash/gstmpdparser.c @@ -1873,12 +1873,12 @@ gst_mpdparser_parse_representation_node (GList ** list, xmlNode * a_node, if (!gst_mpdparser_get_xml_prop_string_no_whitespace (a_node, "id", &new_representation->id)) { GST_ERROR ("Cannot parse Representation id, invalid manifest"); - return FALSE; + goto error; } if (!gst_mpdparser_get_xml_prop_unsigned_integer (a_node, "bandwidth", 0, &new_representation->bandwidth)) { GST_ERROR ("Cannot parse Representation bandwidth, invalid manifest"); - return FALSE; + goto error; } gst_mpdparser_get_xml_prop_unsigned_integer (a_node, "qualityRanking", 0, &new_representation->qualityRanking);