From 92f9e6ad775790f6d4e6aa696dc20efb9ca3473f Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Tue, 30 May 2006 16:09:36 +0000 Subject: [PATCH] ext/pango/gsttextoverlay.c: Added some FIXMEs. Original commit message from CVS: * ext/pango/gsttextoverlay.c: (gst_text_overlay_src_event), (gst_text_overlay_text_event): Added some FIXMEs. --- ChangeLog | 6 ++++++ ext/pango/gsttextoverlay.c | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 63216f9731..10a58a3a26 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2006-05-30 Wim Taymans + + * ext/pango/gsttextoverlay.c: (gst_text_overlay_src_event), + (gst_text_overlay_text_event): + Added some FIXMEs. + 2006-05-30 Wim Taymans * gst/adder/gstadder.c: (gst_adder_class_init), (gst_adder_init), diff --git a/ext/pango/gsttextoverlay.c b/ext/pango/gsttextoverlay.c index 11d0d5585e..2caa7674d1 100644 --- a/ext/pango/gsttextoverlay.c +++ b/ext/pango/gsttextoverlay.c @@ -698,7 +698,7 @@ gst_text_overlay_src_event (GstPad * pad, GstEvent * event) GST_DEBUG_OBJECT (overlay, "seek received, driving from here"); - /* Flush downstream */ + /* Flush downstream, FIXME, only for flushing seek */ gst_pad_push_event (overlay->srcpad, gst_event_new_flush_start ()); /* Mark ourself as flushing, unblock chains */ @@ -1090,6 +1090,7 @@ gst_text_overlay_text_event (GstPad * pad, GstEvent * event) case GST_EVENT_EOS: GST_OBJECT_LOCK (overlay); /* We use flushing to make sure we return WRONG_STATE */ + /* FIXME, after EOS a _pad_push() returns _UNEXPECTED */ overlay->text_flushing = TRUE; /* We don't signal anything here because we want to keep the last queued buffer until video pad receives EOS or discard the buffer */