From 92576e7db83a548fcb54e80e35758a7c10e08cf2 Mon Sep 17 00:00:00 2001 From: Lyon Wang Date: Mon, 4 Jun 2018 16:35:41 +0800 Subject: [PATCH] player: Fix duration-changed CRITICAL warning if duration did not actually change Check if duration is changed before emitting duration-changed signal https://bugzilla.gnome.org/show_bug.cgi?id=796491 --- gst-libs/gst/player/gstplayer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gst-libs/gst/player/gstplayer.c b/gst-libs/gst/player/gstplayer.c index 8dac3e9f85..5dd340af8b 100644 --- a/gst-libs/gst/player/gstplayer.c +++ b/gst-libs/gst/player/gstplayer.c @@ -1499,7 +1499,8 @@ emit_duration_changed (GstPlayer * self, GstClockTime duration) { gboolean updated = FALSE; - g_return_if_fail (self->cached_duration != duration); + if (self->cached_duration == duration) + return; GST_DEBUG_OBJECT (self, "Duration changed %" GST_TIME_FORMAT, GST_TIME_ARGS (duration));