From 92272b5e5c844aefde1e40d9d129c5d0fe1e45cd Mon Sep 17 00:00:00 2001 From: Vivia Nikolaidou Date: Fri, 8 Feb 2019 13:59:19 +0200 Subject: [PATCH] qtmux: Only write timecode trak for video Recent changes in ccextractor were attaching timecode meta to the closed caption track. We shouldn't write timecode information for the closed caption trak. --- gst/isomp4/gstqtmux.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gst/isomp4/gstqtmux.c b/gst/isomp4/gstqtmux.c index 999b97ad38..dcc28662c3 100644 --- a/gst/isomp4/gstqtmux.c +++ b/gst/isomp4/gstqtmux.c @@ -2800,7 +2800,8 @@ gst_qt_mux_prefill_samples (GstQTMux * qtmux) gst_collect_pads_peek (qtmux->collect, (GstCollectData *) qpad); GstVideoTimeCodeMeta *tc_meta; - if (buffer && (tc_meta = gst_buffer_get_video_time_code_meta (buffer))) { + if (buffer && (tc_meta = gst_buffer_get_video_time_code_meta (buffer)) + && qpad->trak->is_video) { GstVideoTimeCode *tc = &tc_meta->tc; qpad->tc_trak = atom_trak_new (qtmux->context); @@ -4344,6 +4345,9 @@ gst_qt_mux_check_and_update_timecode (GstQTMux * qtmux, GstQTPad * pad, guint32 frames_since_daily_jam; GstQTMuxClass *qtmux_klass = (GstQTMuxClass *) (G_OBJECT_GET_CLASS (qtmux)); + if (!pad->trak->is_video) + return ret; + if (qtmux_klass->format != GST_QT_MUX_FORMAT_QT) return ret;