From 8b87d7bcf76a3831e2c0c78c92d1d465c3bac449 Mon Sep 17 00:00:00 2001
From: Jochen Henneberg <jochen@centricular.com>
Date: Thu, 11 Apr 2024 07:14:39 +0200
Subject: [PATCH] qt: Let plugin documentation show up

* Enabled cc file parsing from hotdoc
* Moved package to plugins-good where it really is
* Fixed section comments

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6603>
---
 subprojects/gst-plugins-good/docs/meson.build       | 1 +
 subprojects/gst-plugins-good/ext/qt/gstplugin.cc    | 4 ++--
 subprojects/gst-plugins-good/ext/qt/gstqtoverlay.cc | 2 +-
 subprojects/gst-plugins-good/ext/qt/gstqtsink.cc    | 2 +-
 subprojects/gst-plugins-good/ext/qt/gstqtsrc.cc     | 3 ++-
 subprojects/gst-plugins-good/ext/qt/qtitem.cc       | 2 +-
 6 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/subprojects/gst-plugins-good/docs/meson.build b/subprojects/gst-plugins-good/docs/meson.build
index 10bf4a1385..07dc6c329d 100644
--- a/subprojects/gst-plugins-good/docs/meson.build
+++ b/subprojects/gst-plugins-good/docs/meson.build
@@ -104,6 +104,7 @@ gst_plugins_doc = run_command(
         cdir / '../ext/*/*.[ch]',
         cdir / '../ext/*/*/*.[ch]',
         cdir / '../gst/*/*.[ch]',
+        cdir / '../ext/*/*.cc',
     '--gst_c_source_filters', excludes,
     '--gst_cache_file', plugins_cache,
     '--include_paths', cdir / '..',
diff --git a/subprojects/gst-plugins-good/ext/qt/gstplugin.cc b/subprojects/gst-plugins-good/ext/qt/gstplugin.cc
index 17ce9ffcbd..d484af0cda 100644
--- a/subprojects/gst-plugins-good/ext/qt/gstplugin.cc
+++ b/subprojects/gst-plugins-good/ext/qt/gstplugin.cc
@@ -41,10 +41,10 @@ plugin_init (GstPlugin * plugin)
 }
 
 #ifndef GST_PACKAGE_NAME
-#define GST_PACKAGE_NAME   "GStreamer Bad Plug-ins (qmake)"
+#define GST_PACKAGE_NAME   "GStreamer Good Plug-ins"
 #define GST_PACKAGE_ORIGIN "Unknown package origin"
 #define GST_LICENSE        "LGPL"
-#define PACKAGE            "gst-plugins-bad (qmake)"
+#define PACKAGE            "gst-plugins-good"
 #define PACKAGE_VERSION    "1.13.0.1"
 #endif
 
diff --git a/subprojects/gst-plugins-good/ext/qt/gstqtoverlay.cc b/subprojects/gst-plugins-good/ext/qt/gstqtoverlay.cc
index 646ef0e026..001bc2e6e4 100644
--- a/subprojects/gst-plugins-good/ext/qt/gstqtoverlay.cc
+++ b/subprojects/gst-plugins-good/ext/qt/gstqtoverlay.cc
@@ -19,7 +19,7 @@
  */
 
 /**
- * SECTION:gstqtoverlay
+ * SECTION:element-qmlgloverlay
  *
  * qmlgloverlay provides a way to render an almost-arbitrary QML scene within
  * GStreamer pipeline using the same OpenGL context that GStreamer uses
diff --git a/subprojects/gst-plugins-good/ext/qt/gstqtsink.cc b/subprojects/gst-plugins-good/ext/qt/gstqtsink.cc
index e3c5e15218..e7bec02c2f 100644
--- a/subprojects/gst-plugins-good/ext/qt/gstqtsink.cc
+++ b/subprojects/gst-plugins-good/ext/qt/gstqtsink.cc
@@ -19,7 +19,7 @@
  */
 
 /**
- * SECTION:gstqtsink
+ * SECTION:element-qmlglsink
  *
  * qmlglsink provides a way to render a video stream as a Qml object inside
  * the Qml scene graph.  This is achieved by providing the incoming OpenGL
diff --git a/subprojects/gst-plugins-good/ext/qt/gstqtsrc.cc b/subprojects/gst-plugins-good/ext/qt/gstqtsrc.cc
index 159d6ef747..6bf9ab624c 100644
--- a/subprojects/gst-plugins-good/ext/qt/gstqtsrc.cc
+++ b/subprojects/gst-plugins-good/ext/qt/gstqtsrc.cc
@@ -19,8 +19,9 @@
  */
 
 /**
- * SECTION:qmlglsrc
+ * SECTION:element-qmlglsrc
  *
+ * A video src that captures a window from a QML view.
  */
 
 #ifdef HAVE_CONFIG_H
diff --git a/subprojects/gst-plugins-good/ext/qt/qtitem.cc b/subprojects/gst-plugins-good/ext/qt/qtitem.cc
index 0a85ab8704..2b9023d02a 100644
--- a/subprojects/gst-plugins-good/ext/qt/qtitem.cc
+++ b/subprojects/gst-plugins-good/ext/qt/qtitem.cc
@@ -730,7 +730,7 @@ QtGLVideoItem::onSceneGraphInvalidated ()
   GST_FIXME ("%p scene graph invalidated", this);
 }
 
-/**
+/*
  * Retrieve and populate the GL context information from the current
  * OpenGL context.
  */