From 8abfd9d7206c28f9dc49273be0bcff0e4d8f0aeb Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Fri, 23 Jan 2015 15:13:55 +0100 Subject: [PATCH] avimux: Avoid using freed variable the name variable might have been attributed to pad_name, make sure we free it only *after* pad_name has been used. Coverity CID : 1265775 --- gst/avi/gstavimux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gst/avi/gstavimux.c b/gst/avi/gstavimux.c index f0719472f5..225e824cc5 100644 --- a/gst/avi/gstavimux.c +++ b/gst/avi/gstavimux.c @@ -997,8 +997,6 @@ gst_avi_mux_request_new_pad (GstElement * element, newpad = gst_pad_new_from_template (templ, pad_name); - g_free (name); - avipad->collect = gst_collect_pads_add_pad (avimux->collect, newpad, sizeof (GstAviCollectData), NULL, TRUE); ((GstAviCollectData *) (avipad->collect))->avipad = avipad; @@ -1006,6 +1004,8 @@ gst_avi_mux_request_new_pad (GstElement * element, if (!gst_element_add_pad (element, newpad)) goto pad_add_failed; + g_free (name); + GST_DEBUG_OBJECT (newpad, "Added new request pad"); return newpad; @@ -1034,6 +1034,7 @@ too_many_video_pads: pad_add_failed: { GST_WARNING_OBJECT (avimux, "Adding the new pad '%s' failed", pad_name); + g_free (name); gst_object_unref (newpad); return NULL; }