From 8aa5c59b5f78410b26d350731690ddfc1492809d Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Mon, 13 Nov 2017 10:43:11 +0900 Subject: [PATCH] isomp4: Add official fourcc for VP8 codec fourcc for VP8 codec is "vp08" defined by spec. To follow it, add it to demux and change legacy VP8 fourcc "VP80" to "vp08" in mux. Also, enable sync table in case of VP8 codec. See also https://www.webmproject.org/vp9/mp4/ https://bugzilla.gnome.org/show_bug.cgi?id=790026 --- gst/isomp4/fourcc.h | 1 + gst/isomp4/gstqtmux.c | 3 +-- gst/isomp4/qtdemux.c | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/gst/isomp4/fourcc.h b/gst/isomp4/fourcc.h index 3a92e83760..be5c7c04e1 100644 --- a/gst/isomp4/fourcc.h +++ b/gst/isomp4/fourcc.h @@ -251,6 +251,7 @@ G_BEGIN_DECLS #define FOURCC_vc_1 GST_MAKE_FOURCC('v','c','-','1') #define FOURCC_vide GST_MAKE_FOURCC('v','i','d','e') #define FOURCC_vmhd GST_MAKE_FOURCC('v','m','h','d') +#define FOURCC_vp08 GST_MAKE_FOURCC('v','p','0','8') #define FOURCC_vp09 GST_MAKE_FOURCC('v','p','0','9') #define FOURCC_xvid GST_MAKE_FOURCC('x','v','i','d') #define FOURCC_wave GST_MAKE_FOURCC('w','a','v','e') diff --git a/gst/isomp4/gstqtmux.c b/gst/isomp4/gstqtmux.c index 57294fed53..31c8de032c 100644 --- a/gst/isomp4/gstqtmux.c +++ b/gst/isomp4/gstqtmux.c @@ -5346,8 +5346,7 @@ gst_qt_mux_video_sink_set_caps (GstQTPad * qtpad, GstCaps * caps) goto refuse_caps; } } else if (strcmp (mimetype, "video/x-vp8") == 0) { - entry.fourcc = FOURCC_VP80; - sync = FALSE; + entry.fourcc = FOURCC_vp08; } else if (strcmp (mimetype, "video/x-vp9") == 0) { entry.fourcc = FOURCC_vp09; } else if (strcmp (mimetype, "video/x-dirac") == 0) { diff --git a/gst/isomp4/qtdemux.c b/gst/isomp4/qtdemux.c index 6a75301cac..63ddbef8b8 100644 --- a/gst/isomp4/qtdemux.c +++ b/gst/isomp4/qtdemux.c @@ -13937,6 +13937,7 @@ qtdemux_video_caps (GstQTDemux * qtdemux, QtDemuxStream * stream, caps = gst_caps_from_string ("video/x-dnxhd"); break; case FOURCC_VP80: + case FOURCC_vp08: _codec ("On2 VP8"); caps = gst_caps_from_string ("video/x-vp8"); break;