From 899d0c4b3bdcdf91744c8ffb04b0a19dcdc5043d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Mon, 25 Feb 2019 11:23:56 +0000 Subject: [PATCH] matroskademux: fix AV1 caps when there's no codec_data There is no "byte-stream" format for AV1 in Matroska, this was probably cargo-culted from H.264. codec_data / CodecPrivate is now mandatory for AV1 in Matroska[*], but there are sample files out there which don't have it (e.g. some Elecard ones). [*] https://github.com/Matroska-Org/matroska-specification/blob/master/codec/av1.md#codecprivate-1 --- gst/matroska/matroska-demux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gst/matroska/matroska-demux.c b/gst/matroska/matroska-demux.c index 611463c100..b2cd9b5d41 100644 --- a/gst/matroska/matroska-demux.c +++ b/gst/matroska/matroska-demux.c @@ -6274,9 +6274,7 @@ gst_matroska_demux_video_caps (GstMatroskaTrackVideoContext * gst_caps_set_simple (caps, "codec_data", GST_TYPE_BUFFER, priv, NULL); gst_buffer_unref (priv); } else { - GST_WARNING ("No codec data found, assuming output is byte-stream"); - gst_caps_set_simple (caps, "stream-format", G_TYPE_STRING, "byte-stream", - NULL); + GST_WARNING ("No AV1 codec data found!"); } *codec_name = g_strdup_printf ("AOM AV1"); } else if (!strcmp (codec_id, GST_MATROSKA_CODEC_ID_VIDEO_PRORES)) {