From 893c11136b4aa7d8aded3925e3ce59abb4c6dd22 Mon Sep 17 00:00:00 2001 From: Stefan Sauer Date: Thu, 13 Jul 2017 21:55:55 +0200 Subject: [PATCH] aggregator: code cleanups Fix comment typos, some copy'n'paste in logging. Add more doc comments. --- gst-libs/gst/audio/gstaudioaggregator.c | 2 +- gst-libs/gst/base/gstaggregator.c | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/gst-libs/gst/audio/gstaudioaggregator.c b/gst-libs/gst/audio/gstaudioaggregator.c index 398e2cf738..62174c6e8e 100644 --- a/gst-libs/gst/audio/gstaudioaggregator.c +++ b/gst-libs/gst/audio/gstaudioaggregator.c @@ -394,7 +394,7 @@ gst_audio_aggregator_src_event (GstAggregator * agg, GstEvent * event) gst_event_parse_seek (event, &rate, &seek_format, &flags, &start_type, &start, &stop_type, &stop); - /* Check the seeking parametters before linking up */ + /* Check the seeking parameters before linking up */ if ((start_type != GST_SEEK_TYPE_NONE) && (start_type != GST_SEEK_TYPE_SET)) { result = FALSE; diff --git a/gst-libs/gst/base/gstaggregator.c b/gst-libs/gst/base/gstaggregator.c index 315b8b820e..11c7f0db5a 100644 --- a/gst-libs/gst/base/gstaggregator.c +++ b/gst-libs/gst/base/gstaggregator.c @@ -356,6 +356,8 @@ static GstFlowReturn gst_aggregator_pad_chain_internal (GstAggregator * self, * * This method guarantees that @func will be called only once for each * sink pad. + * + * Returns: %FALSE if there are no sinkpads or if @func returned %FALSE */ gboolean gst_aggregator_iterate_sinkpads (GstAggregator * self, @@ -779,9 +781,8 @@ check_events (GstAggregator * self, GstAggregatorPad * pad, gpointer user_data) if (klass == NULL) klass = GST_AGGREGATOR_GET_CLASS (self); - GST_LOG_OBJECT (pad, "Processing %" GST_PTR_FORMAT, event); - if (event) { + GST_LOG_OBJECT (pad, "Processing %" GST_PTR_FORMAT, event); gst_event_ref (event); ret = klass->sink_event (self, pad, event); @@ -794,7 +795,7 @@ check_events (GstAggregator * self, GstAggregatorPad * pad, gpointer user_data) } if (query) { - GST_LOG_OBJECT (pad, "Processing %" GST_PTR_FORMAT, event); + GST_LOG_OBJECT (pad, "Processing %" GST_PTR_FORMAT, query); ret = klass->sink_query (self, pad, query); PAD_LOCK (pad);