From 872b0a65cbc8f0c26cf5c666b43caa003cf6422d Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Sat, 12 Nov 2022 09:58:41 +0100 Subject: [PATCH] pbutils/encoding-profile: Don't leak string array It was never freed Part-of: --- .../gst-libs/gst/pbutils/encoding-profile.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-base/gst-libs/gst/pbutils/encoding-profile.c b/subprojects/gst-plugins-base/gst-libs/gst/pbutils/encoding-profile.c index 11bbbf3f6d..4ff1275c98 100644 --- a/subprojects/gst-plugins-base/gst-libs/gst/pbutils/encoding-profile.c +++ b/subprojects/gst-plugins-base/gst-libs/gst/pbutils/encoding-profile.c @@ -1885,7 +1885,7 @@ create_encoding_stream_profile (gchar * serialized_profile, if (propv[1] && propv[2]) { g_warning ("Wrong format for property: %s, only 1 `=` is expected", prop); - + g_strfreev (propv); return NULL; } @@ -1902,7 +1902,7 @@ create_encoding_stream_profile (gchar * serialized_profile, if (!gst_value_deserialize (&v, propv[1])) { g_warning ("Invalid value for property 'single-segment': %s", propv[1]); - + g_strfreev (propv); return NULL; } @@ -1910,6 +1910,7 @@ create_encoding_stream_profile (gchar * serialized_profile, g_value_reset (&v); } else { g_warning ("Unsupported property: %s", propv[0]); + g_strfreev (propv); return NULL; } @@ -1918,9 +1919,11 @@ create_encoding_stream_profile (gchar * serialized_profile, if (endptr == strprops_v[1]) { g_warning ("Wrong presence %s", presence_str); + g_strfreev (propv); return NULL; } } + g_strfreev (propv); } } else { /* We have no presence */ if (preset_v[1]) { /* Not presence but preset */