From 84b1ee4987926fe2dbca2c298870b43a38246ecd Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Mon, 19 Nov 2012 16:04:01 +0100 Subject: [PATCH] rtsp: detect npt time parse errors --- gst-libs/gst/rtsp/gstrtsprange.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gst-libs/gst/rtsp/gstrtsprange.c b/gst-libs/gst/rtsp/gstrtsprange.c index 3bb3b30ff3..d77965cb97 100644 --- a/gst-libs/gst/rtsp/gstrtsprange.c +++ b/gst-libs/gst/rtsp/gstrtsprange.c @@ -86,7 +86,9 @@ parse_npt_time (const gchar * str, GstRTSPTime * time) } else if (strstr (str, ":")) { gint hours, mins; - sscanf (str, "%2d:%2d:", &hours, &mins); + if (sscanf (str, "%2d:%2d:", &hours, &mins) != 2) + return GST_RTSP_EINVAL; + str = strchr (str, ':') + 1; str = strchr (str, ':') + 1; time->type = GST_RTSP_TIME_SECONDS;