From 84a58b3633a8c18d90f359b3cbf601dd0518ac02 Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Tue, 7 Apr 2020 17:04:30 -0400 Subject: [PATCH] h265parse: Fix content light level value changes The comparision was not testing anything meaninful. This fixes the comparision so we now update the caps whenever the value differ. This was detected by coverity. CID 1461291 --- gst/videoparsers/gsth265parse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gst/videoparsers/gsth265parse.c b/gst/videoparsers/gsth265parse.c index 3aa7364cb5..1477976d76 100644 --- a/gst/videoparsers/gsth265parse.c +++ b/gst/videoparsers/gsth265parse.c @@ -654,8 +654,8 @@ gst_h265_parse_process_sei (GstH265Parse * h265parse, GstH265NalUnit * nalu) if (h265parse->content_light_level_state == GST_H265_PARSE_SEI_EXPIRED) { h265parse->update_caps = TRUE; } else if (cll.max_content_light_level != - h265parse->content_light_level.max_frame_average_light_level || - cll.max_content_light_level != + h265parse->content_light_level.max_content_light_level || + cll.max_frame_average_light_level != h265parse->content_light_level.max_frame_average_light_level) { h265parse->update_caps = TRUE; }