From 8445685a21b7c912595827646ef2900ebc84a100 Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Tue, 7 Jan 2020 01:20:24 +0900 Subject: [PATCH] splitmuxsink: Fix assertion failure on set_property() GValue might have null object. (gst-inspect-1.0:10304): GStreamer-CRITICAL ... gst_object_ref_sink: assertion 'object != NULL' failed --- gst/multifile/gstsplitmuxsink.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gst/multifile/gstsplitmuxsink.c b/gst/multifile/gstsplitmuxsink.c index 373b671d7d..7944612948 100644 --- a/gst/multifile/gstsplitmuxsink.c +++ b/gst/multifile/gstsplitmuxsink.c @@ -731,18 +731,18 @@ gst_splitmux_sink_set_property (GObject * object, guint prop_id, break; case PROP_SINK: GST_OBJECT_LOCK (splitmux); - if (splitmux->provided_sink) - gst_object_unref (splitmux->provided_sink); + gst_clear_object (&splitmux->provided_sink); splitmux->provided_sink = g_value_get_object (value); - gst_object_ref_sink (splitmux->provided_sink); + if (splitmux->provided_sink) + gst_object_ref_sink (splitmux->provided_sink); GST_OBJECT_UNLOCK (splitmux); break; case PROP_MUXER: GST_OBJECT_LOCK (splitmux); - if (splitmux->provided_muxer) - gst_object_unref (splitmux->provided_muxer); + gst_clear_object (&splitmux->provided_muxer); splitmux->provided_muxer = g_value_get_object (value); - gst_object_ref_sink (splitmux->provided_muxer); + if (splitmux->provided_muxer) + gst_object_ref_sink (splitmux->provided_muxer); GST_OBJECT_UNLOCK (splitmux); break; case PROP_RESET_MUXER: