From 8194ab13f7f7bb00d3ba2f4eda9dc5e18fb6ff2a Mon Sep 17 00:00:00 2001 From: Havard Graff Date: Fri, 19 Mar 2021 18:19:43 +0100 Subject: [PATCH] rtptwcc: make enabling TWCC sticky Meaning that if a caps comes along that does NOT have TWCC in it, this does not turn of TWCC for the rest, as this is in fact completely allowed. (To have some payload-types not containing TWCC seqnums). Part-of: --- gst/rtpmanager/rtptwcc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gst/rtpmanager/rtptwcc.c b/gst/rtpmanager/rtptwcc.c index b5fa79b5d8..47cf8ae0ab 100644 --- a/gst/rtpmanager/rtptwcc.c +++ b/gst/rtpmanager/rtptwcc.c @@ -188,8 +188,9 @@ void rtp_twcc_manager_parse_recv_ext_id (RTPTWCCManager * twcc, const GstStructure * s) { - twcc->recv_ext_id = _get_extmap_id_for_attribute (s, TWCC_EXTMAP_STR); - if (twcc->recv_ext_id > 0) { + guint8 recv_ext_id = _get_extmap_id_for_attribute (s, TWCC_EXTMAP_STR); + if (recv_ext_id > 0) { + twcc->recv_ext_id = recv_ext_id; GST_INFO ("TWCC enabled for recv using extension id: %u", twcc->recv_ext_id); } @@ -199,8 +200,9 @@ void rtp_twcc_manager_parse_send_ext_id (RTPTWCCManager * twcc, const GstStructure * s) { - twcc->send_ext_id = _get_extmap_id_for_attribute (s, TWCC_EXTMAP_STR); - if (twcc->send_ext_id > 0) { + guint8 send_ext_id = _get_extmap_id_for_attribute (s, TWCC_EXTMAP_STR); + if (send_ext_id > 0) { + twcc->send_ext_id = send_ext_id; GST_INFO ("TWCC enabled for send using extension id: %u", twcc->send_ext_id); }