From 808b404e88526b8cf4cba6a32718e649f1390192 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Manuel=20J=C3=A1quez=20Leal?= Date: Tue, 14 Aug 2018 12:36:53 +0200 Subject: [PATCH] closedcaption: avoid implicit convertion of enums When compiling with clang-6 this error pops out: raw_decoder.c:1011:62: error: implicit conversion from enumeration type 'const vbi_modulation' to different enumeration type 'vbi3_modulation' [-Werror,-Wenum-conversion] This is because function vbi3_bit_slicer_set_params() sets vbi3_modulation as enum type parameter, nonetheless vbi_modulation enum is passed. Both enums looks semantically equal, thus the fix is a simple cast. https://bugzilla.gnome.org/show_bug.cgi?id=796957 --- ext/closedcaption/raw_decoder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ext/closedcaption/raw_decoder.c b/ext/closedcaption/raw_decoder.c index b6703f44b1..352384296d 100644 --- a/ext/closedcaption/raw_decoder.c +++ b/ext/closedcaption/raw_decoder.c @@ -1008,7 +1008,8 @@ vbi3_raw_decoder_add_services (vbi3_raw_decoder * rd, par->cri_rate, cri_end, (par->cri_frc & ((1U << par->frc_bits) - 1)), - par->frc_bits, par->payload, par->bit_rate, par->modulation)) { + par->frc_bits, par->payload, par->bit_rate, + (vbi3_modulation) par->modulation)) { assert (!"bit_slicer_set_params"); }