From 8047323e931309d09d3697f0a4848b6043a72f83 Mon Sep 17 00:00:00 2001
From: Thibault Saunier <tsaunier@igalia.com>
Date: Wed, 27 May 2020 19:39:49 -0400
Subject: [PATCH] xml-formatter: Add an GST_ERROR when setting control sources
 fails

CID 1463853

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/180>
---
 ges/ges-base-xml-formatter.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/ges/ges-base-xml-formatter.c b/ges/ges-base-xml-formatter.c
index d9149ccba6..7239ba652e 100644
--- a/ges/ges-base-xml-formatter.c
+++ b/ges/ges-base-xml-formatter.c
@@ -1115,8 +1115,11 @@ ges_base_xml_formatter_add_control_binding (GESBaseXmlFormatter * self,
         property_name, binding_type);
 
     g_object_set (source, "mode", mode, NULL);
-    gst_timed_value_control_source_set_from_list (GST_TIMED_VALUE_CONTROL_SOURCE
-        (source), timed_values);
+    if (!gst_timed_value_control_source_set_from_list
+        (GST_TIMED_VALUE_CONTROL_SOURCE (source), timed_values)) {
+      GST_ERROR_OBJECT (self, "Could not set timed values on %" GES_FORMAT,
+          GES_ARGS (source));
+    }
 
     gst_object_unref (source);
   } else