From 7ebfdbeaf8b41d027cb5b7e50366e4b0323fc74a Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Wed, 16 Apr 2014 16:32:26 +0100 Subject: [PATCH] wavparse: do not rely on call failure keeping return data unmodified This is clearer this way too. Coverity 206029 --- gst/wavparse/gstwavparse.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gst/wavparse/gstwavparse.c b/gst/wavparse/gstwavparse.c index 62886c8fa3..2ac5fc60a6 100644 --- a/gst/wavparse/gstwavparse.c +++ b/gst/wavparse/gstwavparse.c @@ -1601,9 +1601,10 @@ gst_wavparse_stream_headers (GstWavParse * wav) * that is, buffers not too small either size or time wise * so we do not end up with too many of them */ /* var abuse */ - upstream_size = 0; - gst_wavparse_time_to_bytepos (wav, 40 * GST_MSECOND, &upstream_size); - wav->max_buf_size = upstream_size; + if (gst_wavparse_time_to_bytepos (wav, 40 * GST_MSECOND, &upstream_size)) + wav->max_buf_size = upstream_size; + else + wav->max_buf_size = 0; wav->max_buf_size = MAX (wav->max_buf_size, MAX_BUFFER_SIZE); if (wav->blockalign > 0) wav->max_buf_size -= (wav->max_buf_size % wav->blockalign);