From 7eb553e2debfd279d6b1b6fc95b90cdce14d7010 Mon Sep 17 00:00:00 2001 From: Peter Christoffersen Date: Tue, 13 Oct 2009 16:01:26 +0200 Subject: [PATCH] faad2: Don't leak element reference in the setcaps function Fixes bug #598139. --- ext/faad/gstfaad.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ext/faad/gstfaad.c b/ext/faad/gstfaad.c index 5ebb043828..b9de36d117 100644 --- a/ext/faad/gstfaad.c +++ b/ext/faad/gstfaad.c @@ -393,17 +393,20 @@ gst_faad_setcaps (GstPad * pad, GstCaps * caps) if (!faad->packetised) gst_faad_send_tags (faad); + gst_object_unref (faad); return TRUE; /* ERRORS */ wrong_length: { GST_DEBUG_OBJECT (faad, "codec_data less than 2 bytes long"); + gst_object_unref (faad); return FALSE; } init_failed: { GST_DEBUG_OBJECT (faad, "faacDecInit2() failed"); + gst_object_unref (faad); return FALSE; } }