From 7da70e2b9f3eae7821c4bda0eed29106395b8f7a Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Mon, 2 Mar 2020 19:35:16 +1100 Subject: [PATCH] glquery: fix a possible unintialized value A GL driver may not fill the resulting value so initialize it to 0 ourselves. --- gst-libs/gst/gl/gstglquery.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/gst-libs/gst/gl/gstglquery.c b/gst-libs/gst/gl/gstglquery.c index 6f8a988685..588b572bea 100644 --- a/gst-libs/gst/gl/gstglquery.c +++ b/gst-libs/gst/gl/gstglquery.c @@ -114,7 +114,7 @@ static gchar * _log_time (gpointer user_data) { GstGLQuery *query = user_data; - gint64 result; + guint64 result = 0; result = gst_gl_query_result (query); @@ -338,10 +338,11 @@ gst_gl_query_result (GstGLQuery * query) gl = query->context->gl_vtable; if (gl->GetQueryObjectui64v) { - gl->GetQueryObjectui64v (query->query_id, GL_QUERY_RESULT, - (GLuint64 *) & ret); + GLuint64 tmp = 0; + gl->GetQueryObjectui64v (query->query_id, GL_QUERY_RESULT, &tmp); + ret = tmp; } else { - guint tmp; + guint tmp = 0; gl->GetQueryObjectuiv (query->query_id, GL_QUERY_RESULT, &tmp); ret = tmp; }