From 7d2a07076efd385022f9afc453837b99bd92ab2b Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Fri, 18 Nov 2016 22:45:45 +0900 Subject: [PATCH] qtdemux: Remove useless return variable qtdemux_expose_streams() returns flow error immediately, if there is an error. So, the variable for the flow return is not needed. https://bugzilla.gnome.org/show_bug.cgi?id=774674 --- gst/isomp4/qtdemux.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gst/isomp4/qtdemux.c b/gst/isomp4/qtdemux.c index c61a586624..b66c34cc35 100644 --- a/gst/isomp4/qtdemux.c +++ b/gst/isomp4/qtdemux.c @@ -11377,13 +11377,12 @@ static GstFlowReturn qtdemux_expose_streams (GstQTDemux * qtdemux) { gint i; - GstFlowReturn ret = GST_FLOW_OK; GSList *oldpads = NULL; GSList *iter; GST_DEBUG_OBJECT (qtdemux, "exposing streams"); - for (i = 0; ret == GST_FLOW_OK && i < qtdemux->n_streams; i++) { + for (i = 0; i < qtdemux->n_streams; i++) { QtDemuxStream *stream = qtdemux->streams[i]; GstPad *oldpad = stream->pad; GstTagList *list; @@ -11450,7 +11449,7 @@ qtdemux_expose_streams (GstQTDemux * qtdemux) } qtdemux->exposed = TRUE; - return ret; + return GST_FLOW_OK; } /* check if major or compatible brand is 3GP */