From 7c1d700384017327fe685cfadae7b5af097378a6 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Sat, 15 Dec 2018 11:42:30 +0100 Subject: [PATCH] parse: Move variable to block where it's used There was a dead assignment used outside of the bin/pipeline creation which was confusing (and unused). Just move that variable to where it is actually used. (Note that that variable was not needed outside of that block since the refactoring done in 2b33d3318519fd613dd5a4ebbd7c308609904e68 ) --- gst/parse/grammar.y | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gst/parse/grammar.y b/gst/parse/grammar.y index 1150aa2e8f..1aa77edb39 100644 --- a/gst/parse/grammar.y +++ b/gst/parse/grammar.y @@ -1146,7 +1146,6 @@ priv_gst_parse_launch (const gchar *str, GError **error, GstParseContext *ctx, graph_t g; gchar *dstr; GSList *walk; - GstBin *bin = NULL; GstElement *ret; yyscan_t scanner; @@ -1209,6 +1208,7 @@ priv_gst_parse_launch (const gchar *str, GError **error, GstParseContext *ctx, /* put all elements in our bin if necessary */ if(g.chain->elements->next){ + GstBin *bin; if (flags & GST_PARSE_FLAG_PLACE_IN_BIN) bin = GST_BIN (gst_element_factory_make ("bin", NULL)); else @@ -1226,8 +1226,6 @@ priv_gst_parse_launch (const gchar *str, GError **error, GstParseContext *ctx, ret = (GstElement *) g.chain->elements->data; g_slist_free (g.chain->elements); g.chain->elements=NULL; - if (GST_IS_BIN (ret)) - bin = GST_BIN (ret); gst_parse_free_chain (g.chain); g.chain = NULL;