From 7b558e37bc80d40a118f622fd822159a3addd8bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Mon, 19 May 2014 08:45:10 +0200 Subject: [PATCH] omx: Make sure to compare the error codes as unsigned integers so that comparisons >2**31 actually work CID 1214592 --- omx/gstomx.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/omx/gstomx.c b/omx/gstomx.c index 1467465926..04c5502999 100644 --- a/omx/gstomx.c +++ b/omx/gstomx.c @@ -2285,7 +2285,9 @@ gst_omx_get_configuration (void) const gchar * gst_omx_error_to_string (OMX_ERRORTYPE err) { - switch (err) { + guint err_u = (guint) err; + + switch (err_u) { case OMX_ErrorNone: return "None"; case OMX_ErrorInsufficientResources: @@ -2363,11 +2365,11 @@ gst_omx_error_to_string (OMX_ERRORTYPE err) case OMX_ErrorTunnelingUnsupported: return "Tunneling unsupported"; default: - if (err >= (guint32) OMX_ErrorKhronosExtensions - && err < (guint32) OMX_ErrorVendorStartUnused) { + if (err_u >= (guint) OMX_ErrorKhronosExtensions + && err_u < (guint) OMX_ErrorVendorStartUnused) { return "Khronos extension error"; - } else if (err >= (guint32) OMX_ErrorVendorStartUnused - && err < (guint32) OMX_ErrorMax) { + } else if (err_u >= (guint) OMX_ErrorVendorStartUnused + && err_u < (guint) OMX_ErrorMax) { return "Vendor specific error"; } else { return "Unknown error";