From 7a25a4ce025a92fe5dd637e3643d0f8861de39f9 Mon Sep 17 00:00:00 2001
From: Thibault Saunier <tsaunier@igalia.com>
Date: Wed, 13 Oct 2021 00:17:27 -0300
Subject: [PATCH] ges:test: Document some GES failures

Namely races in:
 * check.gst-editing-services.edit_while_seeked_with_stop_it
 * check.gst-editing-services.check_layer_activness_gaps_it

See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/803
and https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/804

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1130>
---
 .../validate/launcher/apps/gstcheck.py        |  1 +
 .../validate/launcher/testsuites/check.py     | 37 ++++++++++++++++++-
 2 files changed, 36 insertions(+), 2 deletions(-)

diff --git a/subprojects/gst-devtools/validate/launcher/apps/gstcheck.py b/subprojects/gst-devtools/validate/launcher/apps/gstcheck.py
index 2fb1f2cfd3..f96b8691d0 100644
--- a/subprojects/gst-devtools/validate/launcher/apps/gstcheck.py
+++ b/subprojects/gst-devtools/validate/launcher/apps/gstcheck.py
@@ -116,6 +116,7 @@ class GstCheckTest(MesonTest):
 
         return env
 
+
 class GstValidateCheckTest(GstValidateTest):
     def __init__(self, name, options, reporter, test_infos, child_env=None):
         ref_env = os.environ.copy()
diff --git a/subprojects/gst-devtools/validate/launcher/testsuites/check.py b/subprojects/gst-devtools/validate/launcher/testsuites/check.py
index cad451ea24..c8db90c877 100644
--- a/subprojects/gst-devtools/validate/launcher/testsuites/check.py
+++ b/subprojects/gst-devtools/validate/launcher/testsuites/check.py
@@ -117,6 +117,7 @@ VALGRIND_BLACKLIST = [
     (r'check.gst-plugins-good.elements_udpsrc.test_udpsrc_empty_packet', 'https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/740')
 ]
 
+
 BLACKLIST = [
     (r'check.gstreamer.gst_gstsystemclock.test_stress_cleanup_unschedule', 'flaky under high server load'),
     (r'check.gstreamer.gst_gstsystemclock.test_stress_reschedule', 'flaky under high server load'),
@@ -188,8 +189,40 @@ KNOWN_ISSUES = {
             r"check.gstreamer.gst_gstbin.test_watch_for_state_change",
         ],
         "max_retries": 1,
-
-    }
+    },
+    "https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/803": {
+        "tests": [
+            "check.gst-editing-services.edit_while_seeked_with_stop"
+        ],
+        "issues": [
+            {
+                'returncode': None,
+                'sometimes': True,
+            },
+            {
+                'timeout': True,
+                'sometimes': True,
+            },
+        ],
+    },
+    "https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/804": {
+        "tests": [
+            "check.gst-editing-services.check_layer_activness_gaps"
+        ],
+        "issues": [
+            {
+                'returncode': 18,
+                'sometimes': True,
+            },
+            {
+                "issue-id": "scenario::execution-error",
+                "summary": "The execution of an action did not properly happen",
+                "level": "critical",
+                "detected-on": "check_layer_activness_gaps.scenario",
+                # "details": "\n> check_layer_activness_gaps.scenario:22\n    22 | check-property, target-element-factory-name=videotestsrc, property-name=pattern, property-value="Blue"\n       >\n       > <src>::pattern expected value: '(gchararray)Blue' different than observed: '(gchararray)"100\%\ Black"'",
+            },
+        ],
+    },
 }