From 78aa922244c2008982b9da4f17817395b042d911 Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Mon, 30 Jan 2006 23:13:05 +0000 Subject: [PATCH] tag: id3v2: Someone should kick my butt. Remove ID3v1 tags from the end of the file. Original commit message from CVS: * gst-libs/gst/tag/gstid3demux.c: (gst_id3demux_chain), (gst_id3demux_read_id3v1), (gst_id3demux_sink_activate), (gst_id3demux_send_tag_event): * gst-libs/gst/tag/id3v2.c: (id3demux_read_id3v1_tag): Someone should kick my butt. Remove ID3v1 tags from the end of the file. Improve error messages. Send the TAG message as soon as we complete typefinding, instead of waiting until we send the first buffer. Downstream tag event is still sent before the first buffer. --- gst-libs/gst/tag/id3v2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gst-libs/gst/tag/id3v2.c b/gst-libs/gst/tag/id3v2.c index 12765e61fe..a14eccef9c 100644 --- a/gst-libs/gst/tag/id3v2.c +++ b/gst-libs/gst/tag/id3v2.c @@ -101,6 +101,8 @@ id3demux_read_id3v1_tag (GstBuffer * buffer, guint * id3v1_size, } else *tags = new_tags; + if (id3v1_size) + *id3v1_size = ID3V1_TAG_SIZE; return ID3TAGS_READ_TAG; }