From 77784c7abacaad35e56f86e938b65947c59f2d18 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Wed, 6 May 2020 11:47:56 +0300 Subject: [PATCH] musepackdec: Don't fail all queries if no sample rate is known yet The sample rate is only needed for the POSITION/DURATION queries and we would otherwise fail important queries like the CAPS query. Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/498 Part-of: --- ext/musepack/gstmusepackdec.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ext/musepack/gstmusepackdec.c b/ext/musepack/gstmusepackdec.c index 8a0da18aad..892828b6bd 100644 --- a/ext/musepack/gstmusepackdec.c +++ b/ext/musepack/gstmusepackdec.c @@ -282,13 +282,13 @@ gst_musepackdec_src_query (GstPad * pad, GstObject * parent, GstQuery * query) samplerate = g_atomic_int_get (&musepackdec->rate); - if (samplerate == 0) - goto done; - switch (GST_QUERY_TYPE (query)) { case GST_QUERY_POSITION:{ gint64 cur, cur_off; + if (samplerate == 0) + goto done; + gst_query_parse_position (query, &format, NULL); GST_OBJECT_LOCK (musepackdec); @@ -308,6 +308,9 @@ gst_musepackdec_src_query (GstPad * pad, GstObject * parent, GstQuery * query) case GST_QUERY_DURATION:{ gint64 len, len_off; + if (samplerate == 0) + goto done; + gst_query_parse_duration (query, &format, NULL); GST_OBJECT_LOCK (musepackdec);