From 76565e8979918a30626137e9ba42f5d48b88e701 Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Thu, 13 Oct 2022 21:35:00 +1100 Subject: [PATCH] adaptivdemux2: Improve a comment about unlocking download requests. Part-of: --- .../ext/adaptivedemux2/gstadaptivedemux-stream.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux-stream.c b/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux-stream.c index 4758d8426d..50b3fb4179 100644 --- a/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux-stream.c +++ b/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux-stream.c @@ -1326,7 +1326,8 @@ on_download_progress (DownloadRequest * request, DownloadRequestState state, G_GUINT64_FORMAT " bytes", gst_buffer_get_size (buffer), request->content_received, request->content_length); - /* Drop the request lock when parsing data. FIXME: Check and comment why this is needed */ + /* Drop the request lock when parsing data. That allows the DownloadHelper to + * add more data while we're parsing (if more arrives) */ download_request_unlock (request); ret = gst_adaptive_demux2_stream_parse_buffer (stream, buffer); download_request_lock (request);