From 748a089a5afcdefdf4c48a95769e85f1b34abab7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Mon, 3 Mar 2008 06:04:31 +0000 Subject: [PATCH] Correct all relevant warnings found by the sparse semantic code analyzer. This include marking several symbols static... Original commit message from CVS: * ext/alsa/gstalsamixertrack.c: (gst_alsa_mixer_track_get_type): * ext/alsa/gstalsasink.c: (set_hwparams): * ext/alsa/gstalsasrc.c: (set_hwparams): * ext/gio/gstgio.c: (gst_gio_uri_handler_get_uri): * ext/ogg/gstoggmux.h: * ext/ogg/gstogmparse.c: * gst-libs/gst/audio/audio.c: * gst-libs/gst/fft/kiss_fft_f64.c: (kiss_fft_f64_alloc): * gst-libs/gst/pbutils/missing-plugins.c: (gst_missing_uri_sink_message_new), (gst_missing_element_message_new), (gst_missing_decoder_message_new), (gst_missing_encoder_message_new): * gst-libs/gst/rtp/gstbasertppayload.c: * gst-libs/gst/rtp/gstrtcpbuffer.c: (gst_rtcp_packet_bye_get_reason): * gst/audioconvert/gstaudioconvert.c: * gst/audioresample/gstaudioresample.c: * gst/ffmpegcolorspace/imgconvert.c: * gst/playback/test.c: (gen_video_element), (gen_audio_element): * gst/typefind/gsttypefindfunctions.c: * gst/videoscale/vs_4tap.c: * gst/videoscale/vs_4tap.h: * sys/v4l/gstv4lelement.c: * sys/v4l/gstv4lsrc.c: (gst_v4lsrc_get_any_caps): * sys/v4l/v4l_calls.c: * sys/v4l/v4lsrc_calls.c: (gst_v4lsrc_capture_init), (gst_v4lsrc_try_capture): * sys/ximage/ximagesink.c: (gst_ximagesink_check_xshm_calls), (gst_ximagesink_ximage_new): * sys/xvimage/xvimagesink.c: (gst_xvimagesink_check_xshm_calls), (gst_xvimagesink_xvimage_new): * tests/check/elements/audioconvert.c: * tests/check/elements/audioresample.c: (fail_unless_perfect_stream): * tests/check/elements/audiotestsrc.c: (setup_audiotestsrc): * tests/check/elements/decodebin.c: * tests/check/elements/gdpdepay.c: (setup_gdpdepay), (setup_gdpdepay_streamheader): * tests/check/elements/gdppay.c: (setup_gdppay), (GST_START_TEST), (setup_gdppay_streamheader): * tests/check/elements/gnomevfssink.c: (setup_gnomevfssink): * tests/check/elements/multifdsink.c: (setup_multifdsink): * tests/check/elements/textoverlay.c: * tests/check/elements/videorate.c: (setup_videorate): * tests/check/elements/videotestsrc.c: (setup_videotestsrc): * tests/check/elements/volume.c: (setup_volume): * tests/check/elements/vorbisdec.c: (setup_vorbisdec): * tests/check/elements/vorbistag.c: * tests/check/generic/clock-selection.c: * tests/check/generic/states.c: (setup), (teardown): * tests/check/libs/cddabasesrc.c: * tests/check/libs/video.c: * tests/check/pipelines/gio.c: * tests/check/pipelines/oggmux.c: * tests/check/pipelines/simple-launch-lines.c: (simple_launch_lines_suite): * tests/check/pipelines/streamheader.c: * tests/check/pipelines/theoraenc.c: * tests/check/pipelines/vorbisdec.c: * tests/check/pipelines/vorbisenc.c: * tests/examples/seek/scrubby.c: * tests/examples/seek/seek.c: (query_positions_elems), (query_positions_pads): * tests/icles/stress-xoverlay.c: (myclock): Correct all relevant warnings found by the sparse semantic code analyzer. This include marking several symbols static, using NULL instead of 0 for pointers and using "foo (void)" instead of "foo ()" for declarations. * win32/common/libgstrtp.def: Add gst_rtp_buffer_set_extension_data to the symbol definition file. --- tests/check/elements/gdpdepay.c | 16 +++++++--------- tests/check/elements/gdppay.c | 27 +++++++++++++-------------- tests/check/pipelines/streamheader.c | 6 +++--- 3 files changed, 23 insertions(+), 26 deletions(-) diff --git a/tests/check/elements/gdpdepay.c b/tests/check/elements/gdpdepay.c index 119f1cdff8..703e0ade8f 100644 --- a/tests/check/elements/gdpdepay.c +++ b/tests/check/elements/gdpdepay.c @@ -25,12 +25,10 @@ #include #include -gboolean have_eos = FALSE; - /* For ease of programming we use globals to keep refs for our floating * src and sink pads we create; otherwise we always have to do get_pad, * get_peer, and then remove references in every test function */ -GstPad *mysrcpad, *mysinkpad, *myshsinkpad; +static GstPad *mysrcpad, *mysinkpad, *myshsinkpad; #define AUDIO_CAPS_TEMPLATE_STRING \ "audio/x-raw-int, " \ @@ -63,8 +61,8 @@ static GstStaticPadTemplate srctemplate = GST_STATIC_PAD_TEMPLATE ("src", ); /* takes over reference for outcaps */ -GstElement * -setup_gdpdepay () +static GstElement * +setup_gdpdepay (void) { GstElement *gdpdepay; @@ -78,7 +76,7 @@ setup_gdpdepay () return gdpdepay; } -void +static void cleanup_gdpdepay (GstElement * gdpdepay) { GST_DEBUG ("cleanup_gdpdepay"); @@ -266,8 +264,8 @@ static GstStaticPadTemplate shsinktemplate = GST_STATIC_PAD_TEMPLATE ("sink", GST_STATIC_CAPS ("application/x-gst-test-streamheader") ); -GstElement * -setup_gdpdepay_streamheader () +static GstElement * +setup_gdpdepay_streamheader (void) { GstElement *gdpdepay; @@ -402,7 +400,7 @@ GST_END_TEST; #endif /* ifndef HAVE_CPU_PPC64 */ -Suite * +static Suite * gdpdepay_suite (void) { Suite *s = suite_create ("gdpdepay"); diff --git a/tests/check/elements/gdppay.c b/tests/check/elements/gdppay.c index 80f386fe82..267b266dc0 100644 --- a/tests/check/elements/gdppay.c +++ b/tests/check/elements/gdppay.c @@ -24,12 +24,10 @@ #include #include -gboolean have_eos = FALSE; - /* For ease of programming we use globals to keep refs for our floating * src and sink pads we create; otherwise we always have to do get_pad, * get_peer, and then remove references in every test function */ -GstPad *mysrcpad, *myshsrcpad, *mysinkpad; +static GstPad *mysrcpad, *myshsrcpad, *mysinkpad; #define AUDIO_CAPS_TEMPLATE_STRING \ "audio/x-raw-int, " \ @@ -62,8 +60,8 @@ static GstStaticPadTemplate srctemplate = GST_STATIC_PAD_TEMPLATE ("src", ); /* takes over reference for outcaps */ -GstElement * -setup_gdppay () +static GstElement * +setup_gdppay (void) { GstElement *gdppay; @@ -77,7 +75,7 @@ setup_gdppay () return gdppay; } -void +static void cleanup_gdppay (GstElement * gdppay) { GST_DEBUG ("cleanup_gdppay"); @@ -204,7 +202,7 @@ GST_START_TEST (test_audio) g_list_free (buffers); buffers = NULL; ASSERT_OBJECT_REFCOUNT (gdppay, "gdppay", 1); - gst_object_unref (gdppay); + cleanup_gdppay (gdppay); } GST_END_TEST; @@ -216,8 +214,8 @@ static GstStaticPadTemplate shsrctemplate = GST_STATIC_PAD_TEMPLATE ("src", ); -GstElement * -setup_gdppay_streamheader () +static GstElement * +setup_gdppay_streamheader (void) { GstElement *gdppay; @@ -378,7 +376,7 @@ GST_START_TEST (test_streamheader) g_list_free (buffers); buffers = NULL; ASSERT_OBJECT_REFCOUNT (gdppay, "gdppay", 1); - gst_object_unref (gdppay); + cleanup_gdppay (gdppay); } GST_END_TEST; @@ -411,7 +409,7 @@ GST_START_TEST (test_first_no_caps) g_list_free (buffers); buffers = NULL; ASSERT_OBJECT_REFCOUNT (gdppay, "gdppay", 1); - gst_object_unref (gdppay); + cleanup_gdppay (gdppay); } GST_END_TEST; @@ -434,6 +432,7 @@ GST_START_TEST (test_first_no_new_segment) inbuffer = gst_buffer_new_and_alloc (4); caps = gst_caps_from_string (AUDIO_CAPS_STRING); gst_buffer_set_caps (inbuffer, caps); + gst_caps_unref (caps); ASSERT_BUFFER_REFCOUNT (inbuffer, "inbuffer", 1); @@ -452,7 +451,7 @@ GST_START_TEST (test_first_no_new_segment) g_list_free (buffers); buffers = NULL; ASSERT_OBJECT_REFCOUNT (gdppay, "gdppay", 1); - gst_object_unref (gdppay); + cleanup_gdppay (gdppay); } GST_END_TEST; @@ -542,13 +541,13 @@ GST_START_TEST (test_crc) g_list_free (buffers); buffers = NULL; ASSERT_OBJECT_REFCOUNT (gdppay, "gdppay", 1); - gst_object_unref (gdppay); + cleanup_gdppay (gdppay); } GST_END_TEST; -Suite * +static Suite * gdppay_suite (void) { Suite *s = suite_create ("gdppay"); diff --git a/tests/check/pipelines/streamheader.c b/tests/check/pipelines/streamheader.c index d581482049..ebd86e460b 100644 --- a/tests/check/pipelines/streamheader.c +++ b/tests/check/pipelines/streamheader.c @@ -36,7 +36,7 @@ static int n_tags = 0; -gboolean +static gboolean tag_event_probe_cb (GstPad * pad, GstEvent * event, GMainLoop * loop) { switch (GST_EVENT_TYPE (event)) { @@ -113,7 +113,7 @@ GST_END_TEST; static int n_in_caps = 0; -gboolean +static gboolean buffer_probe_cb (GstPad * pad, GstBuffer * buffer) { if (GST_BUFFER_FLAG_IS_SET (buffer, GST_BUFFER_FLAG_IN_CAPS)) { @@ -208,7 +208,7 @@ GST_END_TEST; #endif /* #ifndef GST_DISABLE_PARSE */ -Suite * +static Suite * streamheader_suite (void) { Suite *s = suite_create ("streamheader");