From 7459bee9794c1f91ea17a63804434228adfc294b Mon Sep 17 00:00:00 2001
From: He Junyan <junyan.he@hotmail.com>
Date: Fri, 10 Apr 2020 22:04:34 +0800
Subject: [PATCH] plugins: encode: Modify sink template of mpeg2 encode.

Use gst_vaapi_detect_codec_caps to get more precise template caps.
Also implement gst_vaapiencode_mpeg2_register_type, which should be
called at plugin register time.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/315>
---
 gst/vaapi/gstvaapiencode_mpeg2.c | 36 +++++++++-----------------------
 gst/vaapi/gstvaapiencode_mpeg2.h |  3 +++
 2 files changed, 13 insertions(+), 26 deletions(-)

diff --git a/gst/vaapi/gstvaapiencode_mpeg2.c b/gst/vaapi/gstvaapiencode_mpeg2.c
index 06b3458ca8..d898533d11 100644
--- a/gst/vaapi/gstvaapiencode_mpeg2.c
+++ b/gst/vaapi/gstvaapiencode_mpeg2.c
@@ -51,29 +51,11 @@ GST_DEBUG_CATEGORY_STATIC (gst_vaapi_mpeg2_encode_debug);
   "video/mpeg, mpegversion = (int) 2, "         \
   "systemstream = (boolean) false"
 
-/* *INDENT-OFF* */
-static const char gst_vaapiencode_mpeg2_sink_caps_str[] =
-  GST_VAAPI_MAKE_SURFACE_CAPS ", "
-  GST_CAPS_INTERLACED_FALSE "; "
-  GST_VIDEO_CAPS_MAKE (GST_VAAPI_FORMATS_ALL) ", "
-  GST_CAPS_INTERLACED_FALSE ";"
-  GST_VIDEO_CAPS_MAKE_WITH_FEATURES(GST_CAPS_FEATURE_MEMORY_DMABUF, GST_VAAPI_FORMATS_ALL) ","
-  GST_CAPS_INTERLACED_FALSE;
-/* *INDENT-ON* */
-
 /* *INDENT-OFF* */
 static const char gst_vaapiencode_mpeg2_src_caps_str[] =
   GST_CODEC_CAPS;
 /* *INDENT-ON* */
 
-/* *INDENT-OFF* */
-static GstStaticPadTemplate gst_vaapiencode_mpeg2_sink_factory =
-  GST_STATIC_PAD_TEMPLATE ("sink",
-      GST_PAD_SINK,
-      GST_PAD_ALWAYS,
-      GST_STATIC_CAPS (gst_vaapiencode_mpeg2_sink_caps_str));
-/* *INDENT-ON* */
-
 /* *INDENT-OFF* */
 static GstStaticPadTemplate gst_vaapiencode_mpeg2_src_factory =
   GST_STATIC_PAD_TEMPLATE ("src",
@@ -82,9 +64,10 @@ static GstStaticPadTemplate gst_vaapiencode_mpeg2_src_factory =
       GST_STATIC_CAPS (gst_vaapiencode_mpeg2_src_caps_str));
 /* *INDENT-ON* */
 
+#define EXTRA_FORMATS {}
+
 /* mpeg2 encode */
-G_DEFINE_TYPE (GstVaapiEncodeMpeg2, gst_vaapiencode_mpeg2,
-    GST_TYPE_VAAPIENCODE);
+GST_VAAPI_ENCODE_REGISTER_TYPE (mpeg2, MPEG2, Mpeg2, EXTRA_FORMATS);
 
 static void
 gst_vaapiencode_mpeg2_init (GstVaapiEncodeMpeg2 * encode)
@@ -117,16 +100,15 @@ gst_vaapiencode_mpeg2_alloc_encoder (GstVaapiEncode * base,
 }
 
 static void
-gst_vaapiencode_mpeg2_class_init (GstVaapiEncodeMpeg2Class * klass)
+gst_vaapiencode_mpeg2_class_init (GstVaapiEncodeMpeg2Class * klass,
+    gpointer data)
 {
   GObjectClass *const object_class = G_OBJECT_CLASS (klass);
   GstElementClass *const element_class = GST_ELEMENT_CLASS (klass);
   GstVaapiEncodeClass *const encode_class = GST_VAAPIENCODE_CLASS (klass);
+  GstCaps *sink_caps = GST_CAPS_CAST (data);
   gpointer encoder_class;
 
-  GST_DEBUG_CATEGORY_INIT (gst_vaapi_mpeg2_encode_debug,
-      GST_PLUGIN_NAME, 0, GST_PLUGIN_DESC);
-
   object_class->finalize = gst_vaapiencode_mpeg2_finalize;
   object_class->set_property = gst_vaapiencode_set_property_subclass;
   object_class->get_property = gst_vaapiencode_get_property_subclass;
@@ -140,8 +122,10 @@ gst_vaapiencode_mpeg2_class_init (GstVaapiEncodeMpeg2Class * klass)
       GST_PLUGIN_DESC, "Guangxin Xu <guangxin.xu@intel.com>");
 
   /* sink pad */
-  gst_element_class_add_static_pad_template (element_class,
-      &gst_vaapiencode_mpeg2_sink_factory);
+  g_assert (sink_caps);
+  gst_element_class_add_pad_template (element_class,
+      gst_pad_template_new ("sink", GST_PAD_SINK, GST_PAD_ALWAYS, sink_caps));
+  gst_caps_unref (sink_caps);
 
   /* src pad */
   gst_element_class_add_static_pad_template (element_class,
diff --git a/gst/vaapi/gstvaapiencode_mpeg2.h b/gst/vaapi/gstvaapiencode_mpeg2.h
index a2038df62a..a8c765914a 100644
--- a/gst/vaapi/gstvaapiencode_mpeg2.h
+++ b/gst/vaapi/gstvaapiencode_mpeg2.h
@@ -69,6 +69,9 @@ struct _GstVaapiEncodeMpeg2Class
 GType
 gst_vaapiencode_mpeg2_get_type (void) G_GNUC_CONST;
 
+GType
+gst_vaapiencode_mpeg2_register_type (GstVaapiDisplay * display);
+
 G_END_DECLS
 
 #endif /* GST_VAAPIENCODE_MPEG2_H */