From 74546e0323e7621dfaf5b556549bc9b7bc0c623d Mon Sep 17 00:00:00 2001 From: Thomas Vander Stichele Date: Tue, 15 Nov 2005 23:53:08 +0000 Subject: [PATCH] Revert all these unrefs, they don't even pass make check ! Original commit message from CVS: Revert all these unrefs, they don't even pass make check ! --- ChangeLog | 14 ++++++++++++++ gst/base/gstbasesrc.c | 1 - gst/elements/gsttypefindelement.c | 2 -- gst/gstqueue.c | 2 -- gst/gstregistryxml.c | 2 +- libs/gst/base/gstbasesrc.c | 1 - plugins/elements/gstqueue.c | 2 -- plugins/elements/gsttypefindelement.c | 2 -- 8 files changed, 15 insertions(+), 11 deletions(-) diff --git a/ChangeLog b/ChangeLog index 1b989398eeb..f48f2504624 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2005-11-16 Thomas Vander Stichele + + * gst/base/gstbasesrc.c: (gst_base_src_init): + * gst/elements/gsttypefindelement.c: (gst_type_find_element_init): + * gst/gstqueue.c: (gst_queue_init): + * gst/gstregistryxml.c: (load_feature): + Revert all these unrefs, they don't even pass make check ! + 2005-11-15 Johan Dahlin * gst/base/gstbasesrc.c: (gst_base_src_init): @@ -1248,6 +1256,12 @@ * gst/gstelement.c (gst_element_dispose): More helpful message. +2005-10-18 Thomas Vander Stichele + + reviewed by: + + * common/gtk-doc.mak: + 2005-10-18 Thomas Vander Stichele * gst/gstregistry.c: (gst_registry_scan_path_level): diff --git a/gst/base/gstbasesrc.c b/gst/base/gstbasesrc.c index fb7c5ba8634..5231e38974c 100644 --- a/gst/base/gstbasesrc.c +++ b/gst/base/gstbasesrc.c @@ -195,7 +195,6 @@ gst_base_src_init (GstBaseSrc * basesrc, gpointer g_class) GST_DEBUG_OBJECT (basesrc, "creating src pad"); pad = gst_pad_new_from_template (pad_template, "src"); - gst_object_unref (pad_template); GST_DEBUG_OBJECT (basesrc, "setting functions on src pad"); gst_pad_set_activatepush_function (pad, diff --git a/gst/elements/gsttypefindelement.c b/gst/elements/gsttypefindelement.c index 40ad383a71f..6bad7ebd6ca 100644 --- a/gst/elements/gsttypefindelement.c +++ b/gst/elements/gsttypefindelement.c @@ -209,7 +209,6 @@ gst_type_find_element_init (GstTypeFindElement * typefind, /* sinkpad */ src_template = gst_static_pad_template_get (&type_find_element_sink_template); typefind->sink = gst_pad_new_from_template (src_template, "sink"); - gst_object_unref (src_template); gst_pad_set_activate_function (typefind->sink, GST_DEBUG_FUNCPTR (gst_type_find_element_activate)); @@ -222,7 +221,6 @@ gst_type_find_element_init (GstTypeFindElement * typefind, /* srcpad */ sink_template = gst_static_pad_template_get (&type_find_element_src_template); typefind->src = gst_pad_new_from_template (sink_template, "src"); - gst_object_unref (sink_template); gst_pad_set_activatepull_function (typefind->src, GST_DEBUG_FUNCPTR (gst_type_find_element_activate_src_pull)); diff --git a/gst/gstqueue.c b/gst/gstqueue.c index ac0a6af1a30..890f7f5d69e 100644 --- a/gst/gstqueue.c +++ b/gst/gstqueue.c @@ -335,7 +335,6 @@ gst_queue_init (GstQueue * queue) sink_template = gst_static_pad_template_get (&sinktemplate); queue->sinkpad = gst_pad_new_from_template (sink_template, "sink"); - gst_object_unref (sink_template); gst_pad_set_chain_function (queue->sinkpad, GST_DEBUG_FUNCPTR (gst_queue_chain)); @@ -353,7 +352,6 @@ gst_queue_init (GstQueue * queue) src_template = gst_static_pad_template_get (&srctemplate); queue->srcpad = gst_pad_new_from_template (src_template, "src"); - gst_object_unref (src_template); gst_pad_set_activatepush_function (queue->srcpad, GST_DEBUG_FUNCPTR (gst_queue_src_activate_push)); diff --git a/gst/gstregistryxml.c b/gst/gstregistryxml.c index 3f0f26d1825..c44a4f4bba0 100644 --- a/gst/gstregistryxml.c +++ b/gst/gstregistryxml.c @@ -524,7 +524,7 @@ load_feature (xmlTextReaderPtr reader) return NULL; } if (!GST_IS_PLUGIN_FEATURE (feature)) { - gst_object_unref (feature); + g_object_unref (feature); return NULL; } while ((ret = xmlTextReaderRead (reader)) == 1) { diff --git a/libs/gst/base/gstbasesrc.c b/libs/gst/base/gstbasesrc.c index fb7c5ba8634..5231e38974c 100644 --- a/libs/gst/base/gstbasesrc.c +++ b/libs/gst/base/gstbasesrc.c @@ -195,7 +195,6 @@ gst_base_src_init (GstBaseSrc * basesrc, gpointer g_class) GST_DEBUG_OBJECT (basesrc, "creating src pad"); pad = gst_pad_new_from_template (pad_template, "src"); - gst_object_unref (pad_template); GST_DEBUG_OBJECT (basesrc, "setting functions on src pad"); gst_pad_set_activatepush_function (pad, diff --git a/plugins/elements/gstqueue.c b/plugins/elements/gstqueue.c index ac0a6af1a30..890f7f5d69e 100644 --- a/plugins/elements/gstqueue.c +++ b/plugins/elements/gstqueue.c @@ -335,7 +335,6 @@ gst_queue_init (GstQueue * queue) sink_template = gst_static_pad_template_get (&sinktemplate); queue->sinkpad = gst_pad_new_from_template (sink_template, "sink"); - gst_object_unref (sink_template); gst_pad_set_chain_function (queue->sinkpad, GST_DEBUG_FUNCPTR (gst_queue_chain)); @@ -353,7 +352,6 @@ gst_queue_init (GstQueue * queue) src_template = gst_static_pad_template_get (&srctemplate); queue->srcpad = gst_pad_new_from_template (src_template, "src"); - gst_object_unref (src_template); gst_pad_set_activatepush_function (queue->srcpad, GST_DEBUG_FUNCPTR (gst_queue_src_activate_push)); diff --git a/plugins/elements/gsttypefindelement.c b/plugins/elements/gsttypefindelement.c index 40ad383a71f..6bad7ebd6ca 100644 --- a/plugins/elements/gsttypefindelement.c +++ b/plugins/elements/gsttypefindelement.c @@ -209,7 +209,6 @@ gst_type_find_element_init (GstTypeFindElement * typefind, /* sinkpad */ src_template = gst_static_pad_template_get (&type_find_element_sink_template); typefind->sink = gst_pad_new_from_template (src_template, "sink"); - gst_object_unref (src_template); gst_pad_set_activate_function (typefind->sink, GST_DEBUG_FUNCPTR (gst_type_find_element_activate)); @@ -222,7 +221,6 @@ gst_type_find_element_init (GstTypeFindElement * typefind, /* srcpad */ sink_template = gst_static_pad_template_get (&type_find_element_src_template); typefind->src = gst_pad_new_from_template (sink_template, "src"); - gst_object_unref (sink_template); gst_pad_set_activatepull_function (typefind->src, GST_DEBUG_FUNCPTR (gst_type_find_element_activate_src_pull));