From 73f6f466c25a9ed5afb71022a6d921bfcc7e7100 Mon Sep 17 00:00:00 2001 From: Benjamin Otte Date: Tue, 21 May 2019 17:22:04 +0200 Subject: [PATCH] dataurisrc: Fix crash when semicolon is aprt of data This URI is valid: data:,;base64 (It encodes the literal string ";base64") But would lead to a crash because the code assumed the semicolon would be placed before the colon. --- plugins/elements/gstdataurisrc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/elements/gstdataurisrc.c b/plugins/elements/gstdataurisrc.c index 316966f5f2..79521fa0db 100644 --- a/plugins/elements/gstdataurisrc.c +++ b/plugins/elements/gstdataurisrc.c @@ -344,6 +344,9 @@ gst_data_uri_src_set_uri (GstURIHandler * handler, const gchar * uri, if (data_start == NULL) goto invalid_uri; + if (parameters_start > data_start) + parameters_start = NULL; + if (data_start != uri && parameters_start != uri) mimetype = g_strndup (uri,