From 72edd65710b553228750f16f04cad7e91747d5f7 Mon Sep 17 00:00:00 2001 From: Albert Sjolund Date: Fri, 15 Nov 2024 11:44:17 +0100 Subject: [PATCH] rtpmanager: don't map READWRITE in twcc header ext There is no need to map the buffer as writable, as there is only a read performed on the mapped buffer. This is in line with other header extensions, as no other extensions maps it as readwrite. Part-of: --- subprojects/gst-plugins-good/gst/rtpmanager/gstrtphdrext-twcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtphdrext-twcc.c b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtphdrext-twcc.c index 2457337d0b..78412be76c 100644 --- a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtphdrext-twcc.c +++ b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtphdrext-twcc.c @@ -179,7 +179,7 @@ gst_rtp_header_extension_twcc_write (GstRTPHeaderExtension * ext, g_return_val_if_fail (write_flags & gst_rtp_header_extension_twcc_get_supported_flags (ext), -1); - if (!gst_rtp_buffer_map (output, GST_MAP_READWRITE, &rtp)) + if (!gst_rtp_buffer_map (output, GST_MAP_READ, &rtp)) goto map_failed; /* if there already is a twcc-seqnum inside the packet */