From 72df7ab3bdcde0179a7aae0096bf4549da2a40fa Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Fri, 3 Jan 2025 14:30:55 +0100 Subject: [PATCH] test: Avoid type-limit issue MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ``` ../subprojects/gstreamer/tests/check/elements/filesink.c: In function ‘test_seeking’: ../subprojects/gstreamer/tests/check/elements/filesink.c:92:23: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits] 92 | for (i = 0; i < num_bytes; ++i) \ | ^ ../subprojects/gstreamer/tests/check/elements/filesink.c:266:3: note: in expansion of macro ‘PUSH_BYTES’ 266 | PUSH_BYTES (0); | ^~~~~~~~~~ ``` Part-of: --- subprojects/gstreamer/tests/check/elements/filesink.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/subprojects/gstreamer/tests/check/elements/filesink.c b/subprojects/gstreamer/tests/check/elements/filesink.c index 53bc3a9c6f..dcdb358858 100644 --- a/subprojects/gstreamer/tests/check/elements/filesink.c +++ b/subprojects/gstreamer/tests/check/elements/filesink.c @@ -95,6 +95,14 @@ cleanup_filesink (GstElement * filesink) g_rand_free (rand); \ } G_STMT_END +#define PUSH_EMPTY_BUF() \ + G_STMT_START { \ + GstBuffer *buf = gst_buffer_new(); \ + if (sync_buffers) \ + GST_BUFFER_FLAG_SET(buf, GST_BUFFER_FLAG_SYNC_AFTER); \ + fail_unless_equals_int(gst_pad_push(mysrcpad, buf), GST_FLOW_OK); \ + } G_STMT_END + /* Push Buffer with num_mem_blocks memory block each of size num_bytes*/ #define PUSH_BUFFER_WITH_MULTIPLE_MEM_BLOCKS(num_mem_blocks, num_bytes) \ G_STMT_START { \ @@ -261,7 +269,7 @@ GST_START_TEST (test_seeking) CHECK_QUERY_POSITION (filesink, GST_FORMAT_BYTES, 0); /* push buffer with size 0 and NULL data */ - PUSH_BYTES (0); + PUSH_EMPTY_BUF (); CHECK_QUERY_POSITION (filesink, GST_FORMAT_BYTES, 0); PUSH_BYTES (1);