From 6e770e0ebbc9b36fa06a9a3a7b485ee1e8ea97e5 Mon Sep 17 00:00:00 2001 From: Akinobu Mita Date: Sun, 3 Dec 2017 02:10:40 +0900 Subject: [PATCH] ximagesink, xvimagesink: fix incorrect type conversion of pointer position I'm currently playing with modified ximagesink that does XGrabPointer() in order to receive the mouse events occurred outside of the window and send them to the navigation interface. The pointer positions usually have positive coordinates, but it could be negative with that change. When the ximagesink handles XEvent that contains a negative pointer coordinate, it incorrectly generates the GstEvent that contains an extremely large positive pointer coordinate. This is because the negative pointer position in XEvent is incorrectly converted from signed to unsigned and passed as an argument to gst_navigation_send_mouse_event() which causes implicit conversion from integer to double. So the pointer position in the received XEvent and generated GstEvent are completely different. This potential problem does not seem to be a real problem with unmodified ximagesink but there is no reason to leave it as is. This also fixes xvimagesink that has the same potential problem. https://bugzilla.gnome.org/show_bug.cgi?id=791140 --- sys/ximage/ximagesink.c | 2 +- sys/xvimage/xvimagesink.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/ximage/ximagesink.c b/sys/ximage/ximagesink.c index 9176ca69d3..e9615a2942 100644 --- a/sys/ximage/ximagesink.c +++ b/sys/ximage/ximagesink.c @@ -558,7 +558,7 @@ static void gst_x_image_sink_handle_xevents (GstXImageSink * ximagesink) { XEvent e; - guint pointer_x = 0, pointer_y = 0; + gint pointer_x = 0, pointer_y = 0; gboolean pointer_moved = FALSE; gboolean exposed = FALSE, configured = FALSE; diff --git a/sys/xvimage/xvimagesink.c b/sys/xvimage/xvimagesink.c index 4ca0c11352..72ff5745ef 100644 --- a/sys/xvimage/xvimagesink.c +++ b/sys/xvimage/xvimagesink.c @@ -407,7 +407,7 @@ static void gst_xv_image_sink_handle_xevents (GstXvImageSink * xvimagesink) { XEvent e; - guint pointer_x = 0, pointer_y = 0; + gint pointer_x = 0, pointer_y = 0; gboolean pointer_moved = FALSE; gboolean exposed = FALSE, configured = FALSE;