From 6c58f5ee2f97baed5ca36b3504dc4e8026915f76 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Wed, 13 Jul 2016 14:17:25 +0200 Subject: [PATCH] decodebin3: actually check result of accept caps query We were just checking if the query was handled, not its result. Also fix a leak as gst_pad_query() was not consuming the query. https://bugzilla.gnome.org/show_bug.cgi?id=768811 --- gst/playback/gstdecodebin3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gst/playback/gstdecodebin3.c b/gst/playback/gstdecodebin3.c index feeef27b25..fcadbda3ee 100644 --- a/gst/playback/gstdecodebin3.c +++ b/gst/playback/gstdecodebin3.c @@ -1740,8 +1740,8 @@ reconfigure_output_stream (DecodebinOutputStream * output, gboolean can_reuse_decoder; if (needs_decoder) { - GstQuery *q = gst_query_new_accept_caps (new_caps); - can_reuse_decoder = gst_pad_query (output->decoder_sink, q); + can_reuse_decoder = + gst_pad_query_accept_caps (output->decoder_sink, new_caps); } else can_reuse_decoder = FALSE;