From 6ab8345121f2e49001bb24fe1bfe16ec436af433 Mon Sep 17 00:00:00 2001 From: Stefan Kost Date: Sun, 20 Aug 2006 15:55:12 +0000 Subject: [PATCH] gst/gstvalue.*: Use these optimizations only internaly. Original commit message from CVS: * gst/gstvalue.c: * gst/gstvalue.h: Use these optimizations only internaly. --- ChangeLog | 10 ++++++++-- gst/gstvalue.c | 12 ++++++++---- gst/gstvalue.h | 5 ----- 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/ChangeLog b/ChangeLog index 33001b80cb..16e7960eea 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2006-08-20 Stefan Kost + + * gst/gstvalue.c: + * gst/gstvalue.h: + Use these optimizations only internaly. + 2006-08-20 Stefan Kost * gst/gstvalue.c: (gst_value_compare_list), @@ -9,8 +15,8 @@ (gst_value_get_compare_func), (gst_value_compare), (gst_value_compare_with_func): * gst/gstvalue.h: - Saves the expensive lookup of the compare function in many cases - (#345444) + Saves the expensive lookup of the compare function in many cases + (#345444) 2006-08-18 Edward Hervey diff --git a/gst/gstvalue.c b/gst/gstvalue.c index 1f995eadcf..3142f88d6d 100644 --- a/gst/gstvalue.c +++ b/gst/gstvalue.c @@ -82,6 +82,10 @@ static GArray *gst_value_subtract_funcs; static gint gst_greatest_common_divisor (gint a, gint b); static gchar *gst_value_serialize_fraction (const GValue * value); +static GstValueCompareFunc gst_value_get_compare_func (const GValue * value1); +static gint gst_value_compare_with_func (const GValue * value1, + const GValue * value2, GstValueCompareFunc compare); + /******** * list * ********/ @@ -2680,7 +2684,7 @@ gst_value_can_compare (const GValue * value1, const GValue * value2) return FALSE; } -/** +/* * gst_value_get_compare_func: * @value1: a value to get the compare function for * @@ -2689,7 +2693,7 @@ gst_value_can_compare (const GValue * value1, const GValue * value2) * * Returns: A #GstValueCompareFunc value */ -GstValueCompareFunc +static GstValueCompareFunc gst_value_get_compare_func (const GValue * value1) { GstValueTable *table, *best = NULL; @@ -2743,7 +2747,7 @@ gst_value_compare (const GValue * value1, const GValue * value2) return GST_VALUE_UNORDERED; } -/** +/* * gst_value_compare_with_func: * @value1: a value to compare * @value2: another value to compare @@ -2755,7 +2759,7 @@ gst_value_compare (const GValue * value1, const GValue * value2) * * Returns: A #GstValueCompareType value */ -gint +static gint gst_value_compare_with_func (const GValue * value1, const GValue * value2, GstValueCompareFunc compare) { diff --git a/gst/gstvalue.h b/gst/gstvalue.h index 64c097e988..d8242e25f8 100644 --- a/gst/gstvalue.h +++ b/gst/gstvalue.h @@ -485,11 +485,6 @@ gint gst_value_compare (const GValue *value1, const GValue *value2); gboolean gst_value_can_compare (const GValue *value1, const GValue *value2); -GstValueCompareFunc gst_value_get_compare_func (const GValue * value1); -gint gst_value_compare_with_func (const GValue * value1, - const GValue * value2, - GstValueCompareFunc compare); - /* union */ gboolean gst_value_union (GValue *dest, const GValue *value1,